Pass empty pointer to json.Unmarshal when chunking (#2977)

Simon Plourde · ccressent · commit d94ea66db09a · 2019-05-21T12:34:25.000-07:00
Signed-off-by: Simon Plourde &lt;simon@sensu.io&gt;
diff --git a/cli/client/generic.go b/cli/client/generic.go
@@ -46,8 +46,6 @@ func (client *RestClient) List(path string, objs interface{}, options *ListOptio
 		panic("unexpected type for objs")
 	}
 
-	newObjs := reflect.New(objsType.Elem())
-
 	for {
 		request := client.R()
 		ApplyListOptions(request, options)
@@ -61,6 +59,7 @@ func (client *RestClient) List(path string, objs interface{}, options *ListOptio
 			return UnmarshalError(resp)
 		}
 
+		newObjs := reflect.New(objsType.Elem())
 		if err := json.Unmarshal(resp.Body(), newObjs.Interface()); err != nil {
 			return err
 		}

Original file line number	Diff line number	Diff line change
`@@ -46,8 +46,6 @@ func (client RestClient) List(path string, objs interface{}, options ListOptio`
`46`	`46`	`panic("unexpected type for objs")`
`47`	`47`	`}`
`48`	`48`
`49`		`- newObjs := reflect.New(objsType.Elem())`
`50`		`-`
`51`	`49`	`for {`
`52`	`50`	`request := client.R()`
`53`	`51`	`ApplyListOptions(request, options)`
`@@ -61,6 +59,7 @@ func (client RestClient) List(path string, objs interface{}, options ListOptio`
`61`	`59`	`return UnmarshalError(resp)`
`62`	`60`	`}`
`63`	`61`
	`62`	`+ newObjs := reflect.New(objsType.Elem())`
`64`	`63`	`if err := json.Unmarshal(resp.Body(), newObjs.Interface()); err != nil {`
`65`	`64`	`return err`
`66`	`65`	`}`