Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Ability to pass labels/annotations to job pods #217

Open
NetanelK opened this issue Aug 3, 2023 · 1 comment
Open

Feature: Ability to pass labels/annotations to job pods #217

NetanelK opened this issue Aug 3, 2023 · 1 comment

Comments

@NetanelK
Copy link

NetanelK commented Aug 3, 2023

Hi,
currently we're running Istio on our clusters with istio-proxy sidecar injector. We would like to disable istio-proxy on kube-fledged cache pods.

Istio provides a custom label sidecar.istio.io/inject="false" which needs to be present on pod's metadata.

We'll need a way to pass those custom labels to kube-fledged, annotations can be done the same way.
Another less preferred option is to deploy kube-fledged jobs into other namespace that imageCache resource namespace.

@dyens
Copy link

dyens commented Feb 11, 2024

Hi,
Maybe we can simply add sidecar.istio.io/inject="false" in https://github.com/senthilrch/kube-fledged/blob/master/pkg/images/image_helpers.go#L52 ? I can create pr for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants