Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate an internal id when the id is not defined by the connector #160

Closed
NassimBtk opened this issue Apr 24, 2024 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request java wontfix This will not be worked on

Comments

@NassimBtk
Copy link
Member

NassimBtk commented Apr 24, 2024

Is this id required when we discover and collect only one instance?

@NassimBtk There will be cases where we don't want an id attribute, because there is only 1 instance.

Idea: we could consider that if id attribute is not set, then there is a single instance and it's "internal ID" is something like "_singleton" or just the name of the monitor type (in this example: memory?)

Originally posted by @bertysentry in sentrysoftware/metricshub-community-connectors#61 (comment)

@NassimBtk
Copy link
Member Author

We be done through: #341 #342 #343

@NassimBtk NassimBtk added the wontfix This will not be worked on label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request java wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants