Skip to content
This repository has been archived by the owner on Sep 11, 2021. It is now read-only.

about Repo Public #1

Closed
pmh-only opened this issue Jun 17, 2019 · 14 comments
Closed

about Repo Public #1

pmh-only opened this issue Jun 17, 2019 · 14 comments

Comments

@pmh-only
Copy link
Collaborator

이제 이 레포 열어도 되지 않을까요?
@DPS0340
Copy link
Contributor

DPS0340 commented Jun 17, 2019

토큰 때문에...

@pmh-only
Copy link
Collaborator Author

음 그러면 환경변수를 써보는건 어떠신가요

@DPS0340
Copy link
Contributor

DPS0340 commented Jun 17, 2019

커밋 내역에 토큰이 이미 남아서 리보크하지않는한 퍼블릭으로 돌리기는 힘들다는의미였습니다

@DPS0340
Copy link
Contributor

DPS0340 commented Jun 17, 2019

물론 리보크하고 gitignore를 쓰거나 dbms를 쓰면 가능하겠죠

@hwahyang1
Copy link

공개용 레포를 따로 만드는게 낫지 않을까요

@ttakkku
Copy link
Contributor

ttakkku commented Jun 17, 2019

@DPS0340 그렇게 하는 게 좋을 거 같네요

@pmh-only
Copy link
Collaborator Author

@DPS0340 저도 revoke하자는 생각이였습니다

@DPS0340
Copy link
Contributor

DPS0340 commented Jun 17, 2019

제 토큰은 일단 다시 생성하고 숨겼어요

@DPS0340
Copy link
Contributor

DPS0340 commented Jun 17, 2019

.gitignore로 로컬에서만 토큰이 있게...

@pmh-only
Copy link
Collaborator Author

그러면 @ttakkku 레포 공개로 전환해 주세요

@DPS0340
Copy link
Contributor

DPS0340 commented Jun 17, 2019

https://github.com/ttakkku/Filtering/blob/master/python/hynus/filterbot.py
hynus님 토큰 리보크된거 확실한가요?

@pmh-only
Copy link
Collaborator Author

아 hynus님도 계시는구나

@hwahyang1
Copy link

저분 셤기간이라 못쓰실껄요 컴

@pmh-only pmh-only pinned this issue Jun 25, 2019
@pmh-only
Copy link
Collaborator Author

pmh-only commented Aug 9, 2019

이미 처리된 내용이니 닫도록 하겠습니다

@pmh-only pmh-only closed this as completed Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DPS0340 @pmh-only @hwahyang1 @ttakkku