You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 25, 2022. It is now read-only.
I see you migrated to TypeScript. That sounds good but it would be nice if we could maintain backwards compatibility with the types I wrote for DefinitelyTyped. I think we should just copy the DefinitelyTyped tests file over. However, since the project is now written in TypeScript it should be possible to make flux-standard-action and redux peer-dependencies of the package. The easiest way to fix compatibility would then be to copy the corresponding definitions over to the project and mapping them to your code base. I could at least create a PR that does the minimum to make this work.
The text was updated successfully, but these errors were encountered:
Did you take a look at the pull request? Let me know what you think. Be straight about your thoughts. No need to sugar coat things. People seem to have lots of opinions when it comes to type signatures. :-)
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hello!
I see you migrated to TypeScript. That sounds good but it would be nice if we could maintain backwards compatibility with the types I wrote for DefinitelyTyped. I think we should just copy the DefinitelyTyped tests file over. However, since the project is now written in TypeScript it should be possible to make
flux-standard-action
andredux
peer-dependencies of the package. The easiest way to fix compatibility would then be to copy the corresponding definitions over to the project and mapping them to your code base. I could at least create a PR that does the minimum to make this work.The text was updated successfully, but these errors were encountered: