Skip to content
This repository has been archived by the owner on May 25, 2022. It is now read-only.

Update types to match DefinitelyTyped #14

Open
cyberixae opened this issue Nov 20, 2019 · 3 comments
Open

Update types to match DefinitelyTyped #14

cyberixae opened this issue Nov 20, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@cyberixae
Copy link

Hello!

I see you migrated to TypeScript. That sounds good but it would be nice if we could maintain backwards compatibility with the types I wrote for DefinitelyTyped. I think we should just copy the DefinitelyTyped tests file over. However, since the project is now written in TypeScript it should be possible to make flux-standard-action and redux peer-dependencies of the package. The easiest way to fix compatibility would then be to copy the corresponding definitions over to the project and mapping them to your code base. I could at least create a PR that does the minimum to make this work.

@cyberixae cyberixae added the bug Something isn't working label Nov 20, 2019
@cyberixae
Copy link
Author

Or we can make them dev dependencies if we only need the type information.

@cyberixae
Copy link
Author

PR #15 contains my suggestion for attaching the existing types to the code base.

@cyberixae
Copy link
Author

Did you take a look at the pull request? Let me know what you think. Be straight about your thoughts. No need to sugar coat things. People seem to have lots of opinions when it comes to type signatures. :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants