Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DMS-68] Implement mapFilter using foldLeft instad of iter #14

Closed
wants to merge 1 commit into from
Closed

[DMS-68] Implement mapFilter using foldLeft instad of iter #14

wants to merge 1 commit into from
+6 −10

Conversation

s-and-witch
Copy link
Collaborator

In comparison with #12

size foldLeft foldRight mapfilter map
persistentmap 100 18_597 18_509 97_613 29_443
persistentmap_baseline 100 18_597 18_509 157_384 29_048
persistentmap 1000 154_997 153_509 1_763_344 258_079
persistentmap_baseline 1000 154_997 153_509 2_355_770 1_332_475
persistentmap 10000 1_521_863 1_503_632 36_132_684 2_544_359
persistentmap_baseline 10000 1_521_863 1_503_632 42_053_834 2_544_359
persistentmap 100000 15_198_893 15_004_493 434_003_881 132_210_500
persistentmap_baseline 100000 15_198_893 15_004_493 493_211_693 132_210_500
persistentmap 1000000 151_997_225 150_013_513 5_045_781_583 1_322_035_748
persistentmap_baseline 1000000 151_997_225 150_013_513 5_637_834_835 1_322_035_748

@s-and-witch s-and-witch mentioned this pull request Oct 10, 2024
Closed
@s-and-witch s-and-witch changed the title Implement mapFilter using foldLeft instad of iter [DMS-68] Implement mapFilter using foldLeft instad of iter Oct 10, 2024
@GoPavel
Copy link

GoPavel commented Oct 10, 2024

Nice! Looks good to apply + code reusing

This was referenced Oct 11, 2024
Closed
Closed
Open
Open
@GoPavel
Copy link

GoPavel commented Oct 14, 2024

note: to merge

This was referenced Oct 14, 2024
Merged
Closed
@GoPavel GoPavel added experiment experiment experiment:to-merge Successful optimization that intented to moved to another PR labels Oct 21, 2024
@GoPavel GoPavel closed this Oct 21, 2024
@GoPavel GoPavel removed the experiment experiment label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
experiment:to-merge Successful optimization that intented to moved to another PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-and-witch @GoPavel