Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DMS-68] Deduplicate branches that are the same for red and black nodes #19

Closed
wants to merge 5 commits into from
Closed

[DMS-68] Deduplicate branches that are the same for red and black nodes #19

wants to merge 5 commits into from

Conversation

s-and-witch
Copy link
Collaborator

Attempt to deduplicate branches where we expect the same code for #red and #black nodes.

In comparison with #18

Map comparison

binary_size generate max mem batch_get 50 batch_put 50 batch_remove 50 upgrade
rbtree+100 189_877 225_155 42_540 50_045 135_367 133_686 565_657
persistentmap+100 187_078 205_152 42_600 72_688 125_249 126_969 440_636
persistentmap_baseline+100 187_086 205_152 42_600 53_474 124_854 127_364 440_282
rbtree+1000 189_877 3_118_490 580_948 67_516 181_375 180_396 5_409_805
persistentmap+1000 187_078 2_793_387 568_248 101_073 164_244 172_045 4_153_206
persistentmap_baseline+1000 187_086 2_793_387 568_248 72_497 164_285 172_045 4_153_206
rbtree+10000 189_877 51_301_049 520_428 83_465 224_135 230_257 53_866_589
persistentmap+10000 187_078 46_447_443 480_360 127_340 201_154 220_198 41_210_098
persistentmap_baseline+10000 187_086 46_447_443 480_360 90_438 201_072 220_280 41_210_098
rbtree+100000 189_877 606_914_881 5_200_428 98_012 270_465 276_802 698_928_540
persistentmap+100000 187_078 545_438_270 4_800_360 152_300 240_714 265_019 542_245_665
persistentmap_baseline+100000 187_086 545_438_270 4_800_360 106_504 240_673 265_060 542_245_665
rbtree+1000000 189_877 6_993_676_959 52_000_464 116_417 317_299 330_296 6_988_883_198
persistentmap+1000000 187_078 6_253_448_857 48_000_396 182_366 281_246 316_543 5_422_489_439
persistentmap_baseline+1000000 187_086 6_253_448_857 48_000_396 126_976 281_287 316_543 5_422_489_439

Persistent map API

size foldLeft foldRight mapfilter map
persistentmap 100 27_515 27_627 98_578 29_538
persistentmap_baseline 100 19_787 19_699 90_455 29_538
persistentmap 1000 245_061 245_532 1_666_607 263_679
persistentmap_baseline 1000 167_597 166_109 1_589_456 263_679
persistentmap 10000 2_418_441 2_420_292 33_852_941 2_600_540
persistentmap_baseline 10000 1_648_003 1_629_731 33_082_790 2_600_540
persistentmap 100000 127_962_604 127_968_368 401_683_875 129_765_701
persistentmap_baseline 100000 16_454_053 16_259_653 393_979_788 129_765_701
persistentmap 1000000 1_279_593_891 1_279_609_646 4_629_877_965 1_297_599_225
persistentmap_baseline 1000000 164_559_185 162_575_473 4_552_839_930 1_297_599_225

@s-and-witch s-and-witch force-pushed the wip/s-and-witch/inline-colors-2 branch from 99cea37 to 12daced Compare October 14, 2024 14:05
@GoPavel GoPavel mentioned this pull request Oct 14, 2024
Closed
@GoPavel GoPavel added experiment experiment experiment:do-not-merge Unsuccessful optimization experiment and removed experiment experiment labels Oct 21, 2024
@GoPavel GoPavel closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
experiment:do-not-merge Unsuccessful optimization experiment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-and-witch @GoPavel