Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make query parameter name style configurable #51

Open
skykanin opened this issue Feb 13, 2023 · 1 comment
Open

Make query parameter name style configurable #51

skykanin opened this issue Feb 13, 2023 · 1 comment

Comments

@skykanin
Copy link
Contributor

It would be nice for our use case to be able to configure the query parameter names so that we can choose if the names are camelCased, snake_cased or kebab-cased, i.e. sort_by instead of sortBy. These names are currently hardcoded, but this seems like it would be a useful feature to have in general so I thought I might contribute such a change. Afaict the only query parameter name this would apply to at the moment is "sortBy" as it's the only two word query parameter name. Would this an acceptable change to contribute to servant-util?

@Martoon-00
Copy link
Member

Sounds like a fair concern, your PR would be welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants