Skip to content

Commit 0d71ca3

Browse files
committed
[#539] Load BigSur bottles from release instead of artifacts
Problem: when some bottles are build but then the step fails, the build restarts without re-building the existing bottles. This causes issues because we pick the bottles from the job's artifacts and we only receive those from the second run of the job. Solution: we take the BigSur bottles (after all have been built) from the GitHub release where they have already been uploaded.
1 parent 1107c99 commit 0d71ca3

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

.buildkite/pipeline-for-tags.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -152,15 +152,15 @@ steps:
152152
automatic:
153153
limit: 1
154154

155-
# We use the tag that triggered the pipeline here. Normally, this isn't very resilient,
156-
# but in 'scripts/sync-bottle-hashes.sh' it's only used for informational purposes
155+
# We use the tag that triggered the pipeline here.
156+
# However, this requires that the tag and the release name are the same, which
157+
# in practice it's always the case in this repo.
157158
- label: Add Big Sur bottle hashes to formulae
158159
depends_on:
159160
- "build-bottles-big-sur-arm64"
160161
- "build-bottles-big-sur-x86_64"
161162
if: build.tag =~ /^v.*/
162-
soft_fail: true # No artifacts to download if all the bottles are already built
163163
commands:
164164
- mkdir -p "Big Sur"
165-
- buildkite-agent artifact download "*bottle.tar.gz" "Big Sur/"
165+
- nix develop .#buildkite -c gh release download "$BUILDKITE_TAG" -D "Big Sur/" -p "*big_sur.bottle.tar.gz"
166166
- nix develop .#autorelease -c ./scripts/sync-bottle-hashes.sh "$BUILDKITE_TAG" "Big Sur"

0 commit comments

Comments
 (0)