[#707] Filter snapshots by node's commit hash #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasqu4le
reviewed
Sep 4, 2023
Problem: The setup wizard can download snapshots from a provider with metadata, but it doesn't filter these by Octez version. This can cause issues in case a snapshot has been created with an Octez version that is incompatible with the one being used. Solution: Filter by node's commit hash.
krendelhoff2
force-pushed
the
krendelhoff/#707-filter-snapshots
branch
from
1033e3a to
0fc18fa
Compare
Problem: New stable release have to made, so rc-related changes should be reverted. Solution: Revert them.
pasqu4le
reviewed
Sep 5, 2023
Problem: New stable release have to be made, thus release number should be bumped. Solution: Bump it.
Problem: New stable release was prepared, thus we should return to the previuos state. Solution: Revert changes made for v17.3-3.
Problem: We have to make a new release, so release version should be bumped. Solution: Bump it.
krendelhoff2
force-pushed
the
krendelhoff/#707-filter-snapshots
branch
from
6d217a5 to
3ef9288
Compare
pasqu4le
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: The setup wizard can download snapshots from a provider with metadata, but it doesn't filter these by Octez version. This can cause issues in case a snapshot has been created with an Octez version that is incompatible with the one being used.
Solution: Filter by node's commit hash.
Related issue(s)
Resolves #
Related changes (conditional)
I checked whether I should update the README
I checked whether native packaging works, i.e. native binary packages
can be successfully built.
Stylistic guide (mandatory)