Enable will-change property for servo; merge change_bits_for_longhand (#128)

Signed-off-by: Euclid Ye <[email protected]>

Author: yezhizhen

style/properties/longhands/box.mako.rs

@@ -233,11 +233,12 @@ ${helpers.predefined_type(
     "offset-path",
     "OffsetPath",
     "computed::OffsetPath::none()",
-    engines="gecko",
+    engines="gecko servo",
     flags="CAN_ANIMATE_ON_COMPOSITOR",
     spec="https://drafts.fxtf.org/motion-1/#offset-path-property",
     servo_restyle_damage="reflow_out_of_flow",
     affects="overflow",
+    servo_pref="layout.unimplemented",
 )}
 
 // Motion Path Module Level 1
@@ -476,10 +477,11 @@ ${helpers.predefined_type(
     "contain",
     "Contain",
     "specified::Contain::empty()",
-    engines="gecko",
+    engines="gecko servo",
     animation_type="none",
     spec="https://drafts.csswg.org/css-contain/#contain-property",
     affects="layout",
+    servo_pref="layout.unimplemented",
 )}
 
 ${helpers.predefined_type(
@@ -554,7 +556,7 @@ ${helpers.predefined_type(
     "will-change",
     "WillChange",
     "computed::WillChange::auto()",
-    engines="gecko",
+    engines="gecko servo",
     animation_type="none",
     spec="https://drafts.csswg.org/css-will-change/#will-change",
     affects="layout",

style/properties/longhands/effects.mako.rs

@@ -59,7 +59,7 @@ ${helpers.predefined_type(
     "backdrop-filter",
     "Filter",
     None,
-    engines="gecko",
+    engines="gecko servo",
     vector=True,
     simple_vector_bindings=True,
     gecko_ffi_name="mBackdropFilters",
@@ -68,6 +68,7 @@ ${helpers.predefined_type(
     gecko_pref="layout.css.backdrop-filter.enabled",
     spec="https://drafts.fxtf.org/filter-effects-2/#propdef-backdrop-filter",
     affects="overflow",
+    servo_pref="layout.unimplemented",
 )}
 
 ${helpers.single_keyword(

style/properties/longhands/svg.mako.rs

@@ -180,7 +180,7 @@ ${helpers.single_keyword(
 ${helpers.predefined_type(
     "mask-image",
     "Image",
-    engines="gecko",
+    engines="gecko servo",
     initial_value="computed::Image::None",
     initial_specified_value="specified::Image::None",
     parse_method="parse_with_cors_anonymous",
@@ -189,6 +189,7 @@ ${helpers.predefined_type(
     extra_prefixes="webkit",
     animation_type="discrete",
     affects="paint",
+    servo_pref="layout.unimplemented",
 )}
 
 ${helpers.predefined_type(

style/properties/longhands/ui.mako.rs

@@ -432,10 +432,11 @@ ${helpers.predefined_type(
     "view-transition-name",
     "ViewTransitionName",
     "computed::ViewTransitionName::none()",
-    engines="gecko",
+    engines="gecko servo",
     animation_type="discrete",
     gecko_pref="dom.viewTransitions.enabled",
     spec="https://drafts.csswg.org/css-view-transitions-1/#view-transition-name-prop",
     affects="",
     enabled_in="ua",
+    servo_pref="layout.unimplemented",
 )}

style/values/specified/box.rs

@@ -968,7 +968,7 @@ pub struct WillChange {
     /// A bitfield with the kind of change that the value will create, based
     /// on the above field.
     #[css(skip)]
-    bits: WillChangeBits,
+    pub bits: WillChangeBits,
 }
 
 impl WillChange {
@@ -1022,10 +1022,6 @@ bitflags! {
     }
 }
 
-#[cfg(feature="servo")]
-fn change_bits_for_longhand(_longhand: LonghandId) -> WillChangeBits { WillChangeBits::empty() }
-
-#[cfg(feature = "gecko")]
 fn change_bits_for_longhand(longhand: LonghandId) -> WillChangeBits {
     match longhand {
         LonghandId::Opacity => WillChangeBits::OPACITY,

style/values/specified/mod.rs

@@ -44,7 +44,7 @@ pub use self::box_::{
     ContainerName, ContainerType, ContentVisibility, Display, Float, LineClamp, Overflow,
     OverflowAnchor, OverflowClipBox, OverscrollBehavior, Perspective, PositionProperty, Resize,
     ScrollSnapAlign, ScrollSnapAxis, ScrollSnapStop, ScrollSnapStrictness, ScrollSnapType,
-    ScrollbarGutter, TouchAction, VerticalAlign, WillChange, Zoom,
+    ScrollbarGutter, TouchAction, VerticalAlign, WillChange, WillChangeBits, Zoom,
 };
 pub use self::color::{
     Color, ColorOrAuto, ColorPropertyValue, ColorScheme, ForcedColorAdjust, PrintColorAdjust,