Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish UI and clean up code #22

Open
10 of 14 tasks
otech47 opened this issue Jan 3, 2019 · 0 comments
Open
10 of 14 tasks

Polish UI and clean up code #22

otech47 opened this issue Jan 3, 2019 · 0 comments

Comments

@otech47
Copy link
Member

otech47 commented Jan 3, 2019

Leaving a checklist here to take care of when we are closer to a stable release. These should only be minor tasks of low priority

Code Cleanup

  • Ensure all instances of var x = require('npm-package') are refactored to ECMA standards as import x from 'npm-package'
  • Ensure all program structure elements including imported variables, functions, and reducer-action types are logically grouped and alphabetized for better readability
  • Remove any unnecessary function call indents (ex: const startOfWeek = moment().startOf('isoWeek') can stay on a single line since it doesn't wrap on most screen sizes
  • Address Close Issue #8 and #12 #15 (comment)

UI Polish

  • Fix alignment for Setblocks scheduled within the same day and make sure the setblock dots (on both the sidebar and the main page are perfect squares instead of rectangles
    screen shot 2019-01-02 at 8 23 06 pm

  • Fix alignment on the empty state UI "This user hasn't committed..."
    screen shot 2019-01-02 at 8 21 45 pm

  • Remove "Set Team" component from Team Page and add a simple "Team" header

  • On the TeamPage, make sure the color bubbles are vertically center-aligned

  • On the TeamPage, make sure the team member names are vertically left-aligned

  • On the TeamPage, remove the filter/sliders icon on the right

  • On the Schedule Page, change "Hours Counter: X" text to "X work hours scheduled"

  • On the SideBar, the small setblocks should be vertically left/center-aligned

  • Change What issues are you going to work on? to `What are you going to work on?

  • When rendering half-setblocks that have been scheduled, the times should show which half is scheduled. So when a half-block is scheduled for 12am - 4am, the user should see either 12am - 2am or 2am - 4am

@otech47 otech47 changed the title Polish UI and cleanup code Polish UI and clean up code Jan 3, 2019
FedeMadoery pushed a commit to FedeMadoery/setblocks that referenced this issue Jan 8, 2019
Code Cleanup
 Alphabetical ordering of imports and actions (in redux)
 Implementation of BlockList to manage and render the Set Blocks, to improve the readability of Schedule Page by reducing your code length
 Enable Submit now is managed through redux

UI Polish
 Fix alignment for Setblocks scheduled within the same day and make sure the setblock dots (on both the sidebar and the main page are perfect squares instead of rectangles - Was Fixed some commits ago in PR "Close Issue setlife-network#9"
 Fix alignment on the empty state UI "This user hasn't committed..." - Was Fixed some commits ago in PR "Close Issue setlife-network#9"
FedeMadoery pushed a commit to FedeMadoery/setblocks that referenced this issue Jan 8, 2019
FedeMadoery pushed a commit to FedeMadoery/setblocks that referenced this issue Jan 9, 2019
Code Cleanup
 Alphabetical ordering of imports and actions (in redux)
 Implementation of BlockList to manage and render the Set Blocks, to improve the readability of Schedule Page by reducing your code length
 Enable Submit now is managed through redux

UI Polish
 Fix alignment for Setblocks scheduled within the same day and make sure the setblock dots (on both the sidebar and the main page are perfect squares instead of rectangles - Was Fixed some commits ago in PR "Close Issue setlife-network#9"
 Fix alignment on the empty state UI "This user hasn't committed..." - Was Fixed some commits ago in PR "Close Issue setlife-network#9"
FedeMadoery pushed a commit to FedeMadoery/setblocks that referenced this issue Jan 9, 2019
UI Polish

  Remove "Set Team" component from Team Page and add a simple "Team" header
  On the TeamPage, make sure the color bubbles are vertically center-aligned
  On the TeamPage, make sure the team member names are vertically left-aligned
  On the TeamPage, remove the filter/sliders icon on the right
  On the SchedulePage, change "Hours Counter: X" text to "X work hours scheduled"
  On the SideBar, the small setblocks should be vertically left/center-aligned
otech47 added a commit that referenced this issue Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants