Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes possible to thread the config of the vite build via the plugin Options #57

Open
sledorze opened this issue Dec 15, 2021 · 4 comments

Comments

@sledorze
Copy link

I'm open to do a PR if it would be accepted

@JakeGinnivan
Copy link
Contributor

@sledorze yep, would definitely accept an improvement around this

sledorze added a commit to Rebaze-fr/nx-plugins-1 that referenced this issue Dec 20, 2021
@sledorze
Copy link
Author

@JakeGinnivan the PR provides a quick insight of what I meant - would that be in line with your thinking?

@sledorze
Copy link
Author

Oh.. yes, this was my original issue; having a typo vit.config.js instead of vite.config.js
2dec854

We can probably not set the config option if not provided then..
I have no more use case; do you still want we do it?

@JakeGinnivan
Copy link
Contributor

Yeah. I think adding the option is good. If you could just make it optional that would be awesome @sledorze

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants