Contribution

[waynehaffenden]

Hey, seen the work you've done on the fork, completed everything and more that I had hoped to one day do! The project for me is basically dead now due to the fact I no longer own a Sony Bravia TV, I'd like to bring in your work to the official NPM package if you create a pull request? I'd also like to add you into the repo as a contributor, I'd like to keep access incase I do something again in the future but would love you to fully take over the plugin if you're interested?

[seydx]

Hello @waynehaffenden

Thank you very much for taking me in. As soon as I have finished writing it I will make a PR.

I would like to add a function that allows the module to automatically detect if the requested method version is available and switch accordingly or give errors if it is not available. As you have described it here: waynehaffenden#9

Started already writing it, but not finished yet.

https://github.com/SeydX/bravia/blob/b1326a7a05486a0bd073f9a0043a5df79fcef35b/src/bravia.js#L141

Also thank you for writing it. Without your work I would probably never have gotten around to it. I use the module to make my TV smart and connect it to Apple Homekit.

I have also opened an issue about the above mentioned function there (seydx/homebridge-bravia-tvos#91)

[waynehaffenden]

Sounds great, love the see the project finally finished, awesome work! I'll await your PR :)

[seydx]

@waynehaffenden

The first steps have been taken. The module can start searching for the desired version or replace the wrong version with the right one. It also checks if the entered method can be found.

What still needs to be done is to check the given parameters.

https://github.com/SeydX/bravia/blob/master/src/service-protocol.js#L78

[waynehaffenden]

@seydx nice one! I've given you push access to the main repo now =) When you push to master, if the version is incremented, it will automatically package and push to NPM :)