Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check parsing of _scroll_id in ES response with some kind of trouble #18

Open
mbumba opened this issue Dec 2, 2020 · 0 comments
Open

Check parsing of _scroll_id in ES response with some kind of trouble #18

mbumba opened this issue Dec 2, 2020 · 0 comments
Labels
investigate The issue needs more investigation at first.

Comments

@mbumba
Copy link
Collaborator

mbumba commented Dec 2, 2020

I noticed that _scroll_id is parsed only if response from ES is absolutely correct (https://github.com/seznam/elasticlient/blob/master/src/scroll.cc#L111). Maybe it should be parsed whenever _scroll_id arrived in ES response. ES documentation says: only the most recently received _scroll_id should be used.
@mbumba mbumba added the investigate The issue needs more investigation at first. label Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
investigate The issue needs more investigation at first.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbumba