Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update global color variables #263

Open
2 tasks
Tracked by #255
codetheweb opened this issue Nov 18, 2023 · 0 comments
Open
2 tasks
Tracked by #255

Update global color variables #263

codetheweb opened this issue Nov 18, 2023 · 0 comments
Assignees
@BrettEastman
Labels
engineering

Comments

@codetheweb
Copy link
Contributor

codetheweb commented Nov 18, 2023 •
edited
Loading

https://www.figma.com/file/m09znscRXNqSziAiEbNLTf/Compass-Designs?type=design&node-id=1-9&mode=design&t=jSmLWiF6iIuSeD4v-0

  • Update globals.css
  • Replace instances of hardcoded hex colors with variable references
@codetheweb codetheweb mentioned this issue Nov 18, 2023
Open
12 tasks
@tessathornberry tessathornberry mentioned this issue Dec 5, 2023
Open
@BrettEastman BrettEastman self-assigned this Jan 30, 2024
BrettEastman added a commit that referenced this issue Apr 30, 2024
@BrettEastman
fix(#263/color-variables): Merge latest updates from main. Update any…
4a5e11a 
… new hex codes to globals.css variable names.
BrettEastman added a commit that referenced this issue May 7, 2024
@BrettEastman
Update global color variables #263 (#279)
fe6e1f1 
* Check all css variables in globals.css to make sure they represent Figma design system colors. Go through all instances of each hex code and change to color variable, making educated guesses when coming across a hex color value not in the design system.

* Convert rgb colors to css variables, again taking an educated guess at one purple color in uploadImage.module.css file that was not in the design system.

* fix(#263/color-variables): Merge latest updates from main. Update any new hex codes to globals.css variable names.

* fix(263/color-variables): remove duplicate Button.module.css file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrettEastman BrettEastman

Labels
engineering
Projects
Compass
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nickvisut @codetheweb @BrettEastman