Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket disconnects may cancel in-progress uploads for other clients #126

Open
sffc opened this issue Aug 1, 2021 · 4 comments
Open

Socket disconnects may cancel in-progress uploads for other clients #126

sffc opened this issue Aug 1, 2021 · 4 comments
Labels

Comments

@sffc
Copy link
Owner

sffc commented Aug 1, 2021

The _onDisconnect function seems problematic. It is run after any client disconnects, but it cancels file uploads from all clients. This is probably a bug.

See #110

@sffc sffc added the bug label Aug 1, 2021
@sffc sffc changed the title Socket disconnects cancels in-progress uploads for other clients Socket disconnects may cancel in-progress uploads for other clients Aug 1, 2021
@rfox12
Copy link

rfox12 commented Aug 8, 2021

I'm going to try to replicate this bug over the next couple of days.

@rclankhorst
Copy link

Did you happen to be able to replicate this issue? Since this is blocking #110 which has been stale for a while.

@rfox12
Copy link

rfox12 commented Sep 10, 2021

I'm sorry, this package has been a trustworthy workhorse; but my organization is moving away from it in favor of a custom Typescript implementation. Hopefully we'll open source it.

@sffc
Copy link
Owner Author

sffc commented Sep 10, 2021

If you are able to publish your TypeScript library, I would be happy to recommend it as an alternative to this library. The ecosystem has changed a lot since this was written, and I think the next natural step is to have a whole new clean implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants