Skip to content

Commit 16d3098

Browse files
committed
Use URL from authenticator also for local authenticator
This patch is related to the implementation of the MultiAuthenticator in jupyterhub/oauthenticator#459 The issue will be triggered when using more than one local provider or mixing with oauth providers. With multiple providers the template generates a set of buttons to choose from to continue the login process. For OAuth, the user will be sent to the provider login page and the redirect at the end will continue nicely the process. Now for the tricky part: using a local provider (e.g. PAM), the user will be redirected to the "same page" thus the same template will be rendered but this time to show the username/password dialog. This will trip the workflow because of the action URL coming from the settings and not from the authenticator. Therefore when the button is clicked, the user will come back to the original multiple choice page rather than continue the login.
1 parent 92c6a23 commit 16d3098

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

share/jupyterhub/templates/login.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
</a>
2121
</div>
2222
{% else %}
23-
<form action="{{login_url}}?next={{next}}" method="post" role="form">
23+
<form action="{{authenticator_login_url}}?next={{next}}" method="post" role="form">
2424
<div class="auth-form-header">
2525
Sign in
2626
</div>

0 commit comments

Comments
 (0)