Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QWen VL Follow-up Fixes #1897

Open
merrymercy opened this issue Nov 3, 2024 · 0 comments
Open

QWen VL Follow-up Fixes #1897

merrymercy opened this issue Nov 3, 2024 · 0 comments
Assignees

Comments

@merrymercy
Copy link
Contributor

There are still some remaining items to finish the QWen VL support.

  1. There might be a small bug in the image process. The tests in CI will trigger this error sometimes. https://github.com/sgl-project/sglang/actions/runs/11598427301/job/32294256076#step:4:778
  2. This mrope_position_delta is very model specific and seems only related to multi modal.
    self.mrope_position_delta = [] # use mutable object
    We should move this out of class Req. We can pay some costs to recompute it every time if that is possible. Otherwise, we can move that to Class ImageInputs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants