Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fail to build from Docker #885

Closed
3 tasks done
jywangx opened this issue Aug 2, 2024 · 3 comments · Fixed by #900
Closed
3 tasks done

[Bug] Fail to build from Docker #885

jywangx opened this issue Aug 2, 2024 · 3 comments · Fixed by #900

Comments

@jywangx
Copy link

jywangx commented Aug 2, 2024

Checklist

  • 1. I have searched related issues but cannot get the expected help.
  • 2. The bug has not been fixed in the latest version.
  • 3. Please note that if the bug-related issue you submitted lacks corresponding environment info and a minimal reproducible demo, it will be challenging for us to reproduce and resolve the issue, reducing the likelihood of receiving feedback.

Describe the bug

Building from the Dockerfile, got gpg-key error like:

Err:2 https://developer.download.nvidia.com/compute/cuda/repos/ubuntu2204/x86_64  InRelease
  The following signatures couldn't be verified because the public key is not available: NO_PUBKEY A4B469963BF863CC

while executing:

RUN echo 'tzdata tzdata/Areas select America' | debconf-set-selections \
    && echo 'tzdata tzdata/Zones/America select Los_Angeles' | debconf-set-selections \
    && apt-get update -y \
    && apt-get install -y ccache software-properties-common \
    && add-apt-repository ppa:deadsnakes/ppa \
    && apt-get update -y \
    && apt-get install -y python${PYTHON_VERSION} python${PYTHON_VERSION}-dev python${PYTHON_VERSION}-venv python3-pip \
    && if [ "${PYTHON_VERSION}" != "3" ]; then update-alternatives --install /usr/bin/python3 python3 /usr/bin/python${PYTHON_VERSION} 1; fi \
    && python3 --version \
    && python3 -m pip --version \
    && rm -rf /var/lib/apt/lists/* \
    && apt-get clean

It may due to Cuda Repo Signing Key Change is causing package repo update failures

This problem could be fixed by chanaging the value of FROM in Dockerfile to nvidia/cuda:${CUDA_VERSION}-devel-ubuntu20.04 (It's validated on my env and CUDA_VERSION is set to 12.2.2)

Reproduction

docker build --pull --network=host -t sglang0.28 .

Environment

Nothing
@Ying1123
Copy link
Member

Ying1123 commented Aug 2, 2024

Our CI/CD machine can build it successfully. Can you check out the logs here and see whether they are helpful for your debugging?
https://github.com/sgl-project/sglang/actions/runs/10205918382/job/28237724517#step:4:1

@Ying1123
Copy link
Member

Ying1123 commented Aug 3, 2024

@jywangx Could you check if the newest docker image fixed your problem? We have changed the base image to ubuntu 20.04 (#900)

@Ying1123 Ying1123 linked a pull request Aug 3, 2024 that will close this issue
@jywangx
Copy link
Author

jywangx commented Aug 6, 2024

@jywangx Could you check if the newest docker image fixed your problem? We have changed the base image to ubuntu 20.04 (#900)

Thanks it's ok now!

@zhyncs zhyncs closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants