Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments #1

Open
sgreben opened this issue Jan 26, 2018 · 2 comments
Open

Comments #1

sgreben opened this issue Jan 26, 2018 · 2 comments
Assignees

Comments

@sgreben
Copy link
Owner

sgreben commented Jan 26, 2018

No description provided.

@sgreben sgreben added question Further information is requested good first issue Good for newcomers and removed question Further information is requested labels Jan 26, 2018
@sgreben sgreben self-assigned this Jan 26, 2018
@divan
Copy link

divan commented Jan 27, 2018

Nice tool!

I would comment on the package layout, as it looks overcomplicated as for the single binary Go tool. Moving main.go into cmd/ makes sense if there is more than one binary in the repo. Otherwise having main.go in root makes more sense. It also simplifies getting package:
go get -u github.com/sgreben/tjj instead of go get -u github.com/sgreben/tj/cmd/tj

The same goes with pkg/color — no need to create a separate subpackage just for one color abstraction. Simple color.go in the same package would do the job. Namespacing this package with pkg directory also begs for simplification. So I would just move color.go into the root.

@sgreben
Copy link
Owner Author

sgreben commented Feb 2, 2018

Thanks for the comments! I anticipate more things to be factored out into pkg/, so I'd prefer to keep this structure, even if it is overkill at first :)

@sgreben sgreben removed the good first issue Good for newcomers label Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants