Skip to content

Commit 36fce91

Browse files
committed
Set the same cmake_minimum_required for all subprojects and add --build-id=none flag for linker
1 parent cc2867e commit 36fce91

File tree

6 files changed

+11
-11
lines changed

6 files changed

+11
-11
lines changed

libcodec2-android/build.gradle

-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ android {
2626
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
2727
externalNativeBuild {
2828
cmake {
29-
cppFlags ""
3029
}
3130
}
3231
ndk {

libcodec2-android/src/codec2/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
# Please report questions, comments, problems, or patches to the freetel
66
# mailing list: https://lists.sourceforge.net/lists/listinfo/freetel-codec2
77
#
8-
cmake_minimum_required(VERSION 3.13)
8+
cmake_minimum_required(VERSION 3.10)
99
project(CODEC2
1010
VERSION 1.0.5
1111
DESCRIPTION "Next-Generation Digital Voice for Two-Way Radio"

libcodec2-android/src/main/cpp/CMakeLists.txt

+3-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
# Sets the minimum version of CMake required to build the native library.
55

6-
cmake_minimum_required(VERSION 3.4.1)
6+
cmake_minimum_required(VERSION 3.10)
77
set(main_DIR ${CMAKE_SOURCE_DIR})
88
add_library(libcodec2 SHARED IMPORTED)
99
set_target_properties(libcodec2 PROPERTIES IMPORTED_LOCATION
@@ -38,4 +38,5 @@ find_library( # Sets the name of the path variable.
3838
target_link_libraries(
3939
Codec2JNI
4040
libcodec2
41-
${log-lib})
41+
${log-lib}
42+
"-Wl,--build-id=none")

libopus-android/build.gradle

-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ android {
2626
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
2727
externalNativeBuild {
2828
cmake {
29-
cppFlags ""
3029
}
3130
}
3231
ndk {

libopus-android/src/main/cpp/CMakeLists.txt

+6-5
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,14 @@
33

44
# Sets the minimum version of CMake required to build the native library.
55

6-
cmake_minimum_required(VERSION 3.4.1)
6+
cmake_minimum_required(VERSION 3.10)
77
set(main_DIR ${CMAKE_SOURCE_DIR})
88
add_library(libopus SHARED IMPORTED)
99
set_target_properties(libopus PROPERTIES IMPORTED_LOCATION
1010
${main_DIR}/../../../build/imported-lib/${ANDROID_ABI}/libopus.so)
1111

1212
include_directories(${main_DIR}/opus/)
1313

14-
1514
# Searches for a specified prebuilt library and stores the path as a
1615
## variable. Because CMake includes system libraries in the search path by
1716
# default, you only need to specify the name of the public NDK library
@@ -36,6 +35,8 @@ find_library( # Sets the name of the path variable.
3635
# can link multiple libraries, such as libraries you define in this
3736
# build script, prebuilt third-party libraries, or system libraries.
3837
target_link_libraries(
39-
OpusJNI
40-
libopus
41-
${log-lib})
38+
OpusJNI
39+
libopus
40+
${log-lib}
41+
"-Wl,--build-id=none")
42+

libopus-android/src/opus/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
cmake_minimum_required(VERSION 3.1)
1+
cmake_minimum_required(VERSION 3.10)
22
list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")
33

44
include(OpusPackageVersion)

0 commit comments

Comments
 (0)