Skip to content

Commit cc1a059

Browse files
committed
Unicode characters in log and map bubble comments
1 parent 2386ddd commit cc1a059

File tree

5 files changed

+11
-9
lines changed

5 files changed

+11
-9
lines changed

codec2talkie/src/main/java/com/radio/codec2talkie/protocol/aprs/AprsDataPositionReport.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ private byte[] generateCompressedInfo(Position position) {
113113
} else {
114114
buffer.put(" sT".getBytes());
115115
}
116-
buffer.put(position.comment.getBytes());
116+
buffer.put(position.comment.getBytes(StandardCharsets.UTF_8));
117117
// return
118118
buffer.flip();
119119
byte [] binaryInfo = new byte[buffer.remaining()];
@@ -135,7 +135,7 @@ private byte[] generateUncompressedInfo(Position position) {
135135
buffer.put(String.format(Locale.US, "/A=%06d",
136136
UnitTools.metersToFeet(position.altitudeMeters)).getBytes());
137137
}
138-
buffer.put(position.comment.getBytes());
138+
buffer.put(position.comment.getBytes(StandardCharsets.UTF_8));
139139
// return
140140
buffer.flip();
141141
byte [] binaryInfo = new byte[buffer.remaining()];

codec2talkie/src/main/java/com/radio/codec2talkie/protocol/aprs/AprsDataPositionReportMicE.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ public void fromPosition(Position position) {
109109
}
110110

111111
// comment
112-
buffer.put(position.comment.getBytes());
112+
buffer.put(position.comment.getBytes(StandardCharsets.UTF_8));
113113

114114
// return
115115
buffer.flip();

codec2talkie/src/main/java/com/radio/codec2talkie/protocol/aprs/AprsDataTextMessage.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,8 @@ public void fromBinary(String srcCallsign, String dstCallsign, String digipath,
114114
@Override
115115
public byte[] toBinary() {
116116
return (ackId > 0)
117-
? String.format(Locale.US, ":%-9s:%s{%d", dstCallsign, textMessage, ackId).getBytes()
118-
: String.format(":%-9s:%s", dstCallsign, textMessage).getBytes();
117+
? String.format(Locale.US, ":%-9s:%s{%d", dstCallsign, textMessage, ackId).getBytes(StandardCharsets.UTF_8)
118+
: String.format(":%-9s:%s", dstCallsign, textMessage).getBytes(StandardCharsets.UTF_8);
119119
}
120120

121121
@Override

codec2talkie/src/main/java/com/radio/codec2talkie/protocol/aprs/AprsThirdParty.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
import com.radio.codec2talkie.protocol.message.TextMessage;
55
import com.radio.codec2talkie.protocol.position.Position;
66

7+
import java.nio.charset.StandardCharsets;
8+
79
public class AprsThirdParty implements AprsData {
810

911
private AprsData _aprsData;
@@ -45,7 +47,7 @@ public void fromBinary(String srcCallsign, String dstCallsign, String digipath,
4547
AprsDataType aprsDataType = new AprsDataType(data.data.charAt(0));
4648
_aprsData = AprsDataFactory.create(aprsDataType);
4749
if (_aprsData == null) return;
48-
_aprsData.fromBinary(data.src, data.dst, data.rawDigipath, data.data.getBytes());
50+
_aprsData.fromBinary(data.src, data.dst, data.rawDigipath, data.data.getBytes(StandardCharsets.UTF_8));
4951
}
5052

5153
@Override

codec2talkie/src/main/java/com/radio/codec2talkie/protocol/ax25/AX25Packet.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
import com.radio.codec2talkie.protocol.aprs.tools.AprsIsData;
66
import com.radio.codec2talkie.tools.DebugTools;
7-
import com.radio.codec2talkie.tools.TextTools;
87

98
import java.nio.BufferUnderflowException;
109
import java.nio.ByteBuffer;
@@ -167,7 +166,7 @@ public boolean digiRepeat() {
167166
if (rptCallsign.isValid) {
168167
if (!isDigiRepeated && rptCallsign.digiRepeat()) {
169168
isDigiRepeated = true;
170-
buf.append(rptCallsign.toString());
169+
buf.append(rptCallsign);
171170
} else {
172171
buf.append(digiPaths[i]);
173172
}
@@ -187,7 +186,8 @@ public String toString() {
187186
path = "," + path;
188187
String info = DebugTools.bytesToDebugString(rawData);
189188
if (!isAudio) {
190-
info = DebugTools.bytesToDebugString(TextTools.stripNulls(rawData));
189+
//info = DebugTools.bytesToDebugString(TextTools.stripNulls(rawData));
190+
info = new String(rawData);
191191
}
192192
return String.format("%s>%s%s:%s", src, dst, path, info);
193193
}

0 commit comments

Comments
 (0)