Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Bottom padding issue Tabs flex wrap scenario #4036

Open
2 tasks done
ridhwaans opened this issue Jun 18, 2024 · 1 comment
Open
2 tasks done

[bug]: Bottom padding issue Tabs flex wrap scenario #4036

ridhwaans opened this issue Jun 18, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ridhwaans
Copy link

Describe the bug

<div className="grid auto-rows-max items-start gap-4 md:gap-8 lg:col-span-2">
        <Tabs defaultValue="All">
          <TabsList className="flex flex-wrap pb-32">
            <TabsTrigger value="All">All</TabsTrigger>
            {itemsCollection.map((item) => (
              <TabsTrigger value={item.name as string}>{item.name}</TabsTrigger>
            ))}
          </TabsList>
          {genres.map((item) => (
            <TabsContent value={item.name as string}>
             /* content */
            </TabsContent>
          ))}
        </Tabs>
      </div>

in the above example, pb-32 is hardcoded because if there is a large tab collection, it breaks into two or more rows, then the background color & padding doesnt extend. If the viewport is resized to md & lower, it is more clear that the Tab component padding doesnt grow/shrink. TabsTrigger clips into below components

Affected component/components

Tabs, TabsContent, TabsList, TabsTrigger

How to reproduce

  1. this may just be a client component issue
  2. add flex flex-wrap to TabList
  3. observe TabContent overlap in position with TabList

Codesandbox/StackBlitz link

No response

Logs

No response

System Info

Mac 14.4, Chrome (latest)

Before submitting

  • I've made research efforts and searched the documentation
  • I've searched for existing issues
@ridhwaans ridhwaans added the bug Something isn't working label Jun 18, 2024
@Lavdewangan1
Copy link

Hi there, is this bug still up and can I work on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants