Skip to content

Follow-up: Restore URL global in tutorial SSR renderer VM #780

Description

@justin808

Problem

The tutorial's browser-backed SSR specs fail because the server-renderer VM does not provide the standard URL global while rendering RouterApp.

Reproduction evidence

  • Exact default/base commit: 4830aa3b687c89f36269896a3ea61232cb1f89b2
  • With the React on Rails RC10 dependency candidate, the build passed but RSpec reported 17 failures out of 50 examples, all on the same SSR path with ReferenceError: URL is not defined.
  • After restoring the exact RC9 base and rebuilding, the focused SSR spec reproduced the same failure in 1 of 2 examples.
  • This therefore predates RC10 and is not evidence of an RC10 regression.

Expected outcome

Provide the required web-platform global in the renderer VM, or adjust the tutorial's server-render path so the focused SSR spec passes on the unchanged default branch. Add a focused regression test that fails without the fix.

Non-goals

  • Do not bundle a React on Rails dependency upgrade into this fix.
  • Do not weaken or skip the SSR assertion.

Discovered during React on Rails 17.0.0.rc.10 fleet validation tracked in shakacode/react_on_rails#3823.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions