Allow `webpack-cli` 6.x (non-breaking) #533

tagliala · 2024-12-22T14:47:18Z

Blocked by:

Fix generator specs (non-breaking, no changes to production code) #536

Close #532

Summary

Pull Request checklist

Add/update test to cover these changes
Update documentation
Update CHANGELOG file

Other Information

Please test

Summary by CodeRabbit

New Features
- Added support for webpack-cli v6.
- Introduced a new configuration option: ensure_consistent_versioning.
Breaking Changes
- Removed methods: verify_file_existence, yarn_install, and check_yarn.
Bug Fixes
- Addressed errors related to the Rails environment.
Documentation
- Improved documentation for the esbuild loader and Yarn PnP usage.

coderabbitai · 2024-12-22T14:47:29Z

Walkthrough

The pull request introduces updates to the Shakapacker library, focusing on expanding compatibility with newer versions of webpack-related tools. The changes primarily involve updating the webpack-cli version constraint to support version 6.x, modifying the CHANGELOG.md to document various improvements and breaking changes, and removing some deprecated methods and configuration options. The updates aim to streamline the library's functionality and improve its compatibility with modern development practices.

Changes

File	Change Summary
`CHANGELOG.md`	Updated to include support for `webpack-cli` v6 and document various changes.
`package.json`	Updated `webpack-cli` version constraint to `^4.9.2
`lib/shakapacker.rb`	Removed `verify_file_existance` method.
`lib/tasks/yarn.rake`	Removed `yarn_install` and `check_yarn` methods.
`config/shakapacker.yml`	Added new configuration option `ensure_consistent_versioning`.

Assessment against linked issues

Objective	Addressed	Explanation
Support webpack-cli 6.x [#532]	✅

Suggested reviewers

justin808

Poem

🐰 Webpack's new version, six and bright,
Shakapacker leaps with coding might!
Dependencies updated with care,
Breaking changes beyond compare,
A rabbit's dance of code delight! 🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

tagliala · 2024-12-22T14:49:03Z

ERROR:  Error installing bundler:
	bundler-2.6.1 requires Ruby version >= 3.1.0. The current ruby version is 3.0.7.220.

Close shakacode#532

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

CHANGELOG.md (1)
15-15: Fix markdown list style inconsistency.

The unordered list uses a dash (-) while the markdownlint tool expects an asterisk (*) to maintain consistent list marker style throughout the document.
-- Allow `webpack-cli` v6. [PR 533](https://github.com/shakacode/shakapacker/pull/533) by [tagliala](https://github.com/tagliala).
+* Allow `webpack-cli` v6. [PR 533](https://github.com/shakacode/shakapacker/pull/533) by [tagliala](https://github.com/tagliala).
🧰 Tools

🪛 Markdownlint (0.37.0)

15-15: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 69122a9 and 8492893.

📒 Files selected for processing (2)

CHANGELOG.md (1 hunks)
package.json (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

package.json

🧰 Additional context used

🪛 Markdownlint (0.37.0)

CHANGELOG.md

15-15: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

🔇 Additional comments (1)

CHANGELOG.md (1)

13-16: LGTM! Clear documentation of the new feature.

The changelog entry properly documents the addition of webpack-cli v6 support with a link to the PR and attribution to the contributor.

🧰 Tools

🪛 Markdownlint (0.37.0)

15-15: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

tagliala mentioned this pull request Dec 27, 2024

Generator specs fail because of bundler [PR attached] #534

Closed

tagliala force-pushed the feature/532-webpack-cli-6 branch from 69122a9 to 6a99b73 Compare December 27, 2024 11:37

tagliala marked this pull request as draft December 27, 2024 11:37

tagliala changed the title ~~Allow webpack-cli 6.x~~ Allow webpack-cli 6.x (non-breaking) Dec 27, 2024

tagliala changed the title ~~Allow webpack-cli 6.x (non-breaking)~~ Allow webpack-cli 6.x (non-breaking, requires #536) Dec 27, 2024

Allow webpack-cli 6.x

8492893

Close shakacode#532

tagliala force-pushed the feature/532-webpack-cli-6 branch from 6a99b73 to 8492893 Compare January 7, 2025 20:39

tagliala changed the title ~~Allow webpack-cli 6.x (non-breaking, requires #536)~~ Allow webpack-cli 6.x (non-breaking) Jan 7, 2025

tagliala marked this pull request as ready for review January 7, 2025 20:46

coderabbitai bot reviewed Jan 7, 2025

View reviewed changes

tomdracz approved these changes Jan 8, 2025

View reviewed changes

tomdracz merged commit 65b88c9 into shakacode:main Jan 8, 2025
45 checks passed

tagliala mentioned this pull request Jan 8, 2025

Test against Rails 8.0 #540

Merged

4 tasks

coderabbitai bot mentioned this pull request Jan 9, 2025

Add troubleshooting section around static paths output when using webpack context #547

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow `webpack-cli` 6.x (non-breaking) #533

Allow `webpack-cli` 6.x (non-breaking) #533

tagliala commented Dec 22, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 22, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

tagliala commented Dec 22, 2024

coderabbitai bot left a comment

Allow webpack-cli 6.x (non-breaking) #533

Allow webpack-cli 6.x (non-breaking) #533

Conversation

tagliala commented Dec 22, 2024 • edited by coderabbitai bot Loading

Summary

Pull Request checklist

Other Information

Summary by CodeRabbit

Summary by CodeRabbit

coderabbitai bot commented Dec 22, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

tagliala commented Dec 22, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

Allow `webpack-cli` 6.x (non-breaking) #533

Allow `webpack-cli` 6.x (non-breaking) #533

tagliala commented Dec 22, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 22, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)