Skip to content

Delete readySelector #10

Description

@Romex91

readySelector is redundant for the abTest() flow. The execution order in preparePage.ts is:

  1. Navigate to URL
  2. Wait for readyEvent (if configured)
  3. Wait for readySelector (if configured) ← this one
  4. Wait for delay (if configured)
  5. Run user's testFn ← user gets full page object here

Since users get the Playwright page in their testFn, they can just write await page.waitForSelector('#app-loaded') themselves — one line of code, no config plumbing needed.

The only case where readySelector isn't redundant is the legacy JSON config path (no testFn callback). But for abTest() tests, it's unnecessary machinery.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions