Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max-len that we had set is not applying #26

Open
justin808 opened this issue Aug 12, 2018 · 0 comments
Open

Max-len that we had set is not applying #26

justin808 opened this issue Aug 12, 2018 · 0 comments
Assignees

Comments

@justin808
Copy link
Member

justin808 commented Aug 12, 2018

If I add this max-len to the local config for https://github.com/shakacode/bootstrap-loader

https://github.com/shakacode/bootstrap-loader/blob/master/.eslintrc

---
extends:
  - eslint-config-shakacode
  - prettier

plugins:
  - prettier

globals:
  __DEBUG__: true
  __BOOTSTRAP_CONFIG__: true

ecmaFeatures:
  restParams: true

rules:
  prettier/prettier: "error"

  space-before-function-paren: [2, "never"]
  import/no-unresolved: 0
  no-underscore-dangle: [ "error", { "allow": [ "__BOOTSTRAP_CONFIG__", "__DEBUG__", "_babelPolyfill" ] } ]

  # https://github.com/benmosher/eslint-plugin-import/issues/340
  import/no-extraneous-dependencies: 0
#  max-len: [2, { "code": 100 }]

Max-len that we had set is not applying

Airbnb latest on master
https://github.com/airbnb/javascript/blob/master/packages/eslint-config-airbnb-base/rules/style.js#L195

    // specify the maximum length of a line in your program
    // https://eslint.org/docs/rules/max-len
    'max-len': ['error', 100, 2, {
      ignoreUrls: true,
      ignoreComments: false,
      ignoreRegExpLiterals: true,
      ignoreStrings: true,
      ignoreTemplateLiterals: true,
    }],

Ours

# Almost identical to airbnb's version, but adds ignore of `import` statements

  # Almost identical to airbnb’s version, but adds ignore of `import` statements
  max-len:
    - 2
    -
      code: 100
      tabWidth: 2
      ignoreUrls: true
@ahangarha ahangarha self-assigned this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants