Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

napa pollutes node_modules causing problems with npm shrinkwrap #6

Closed
mzgoddard opened this issue Mar 26, 2015 · 2 comments
Closed

napa pollutes node_modules causing problems with npm shrinkwrap #6

mzgoddard opened this issue Mar 26, 2015 · 2 comments

Comments

@mzgoddard
Copy link
Collaborator

A project I'm on is using npm shrinkwrap to freeze versions for our project for deployable versions. npm shrinkwrap intentionally will not produce a shrinkwrap if there are any extraneous modules in node_modules. napa usage breaks npm shrinkwrap.
@mzgoddard
Copy link
Collaborator Author

I'm not sure how best to resolve this but node_modules must be only npm dependencies and devDependencies.

@shama
Copy link
Owner

shama commented Mar 26, 2015

Ref shama/napa#20

But I'll just include ember directly in the repo to fix for now.

@shama shama closed this as completed in 9ea5111 Mar 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shama @mzgoddard