Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync src with navalgazer & bump deps #192

Open
wants to merge 201 commits into
base: master
Choose a base branch
from
Open

sync src with navalgazer & bump deps #192

wants to merge 201 commits into from

Conversation

heavyk
Copy link

@heavyk heavyk commented Jun 12, 2015

works with iojs
passes all tests

shama added 30 commits March 19, 2014 21:14
@shama
Add platform and statpoll libs
2bfc68d
@shama
Initial implementation of platform
847ed78
@shama
Fix test, that pattern is actually not supposed to match those folders
8d9f41f
@shama
More robust addLater matching test
ae5176a
@shama
Add flatToTree helper for converting to old style tree
97fb539
@shama
Add deps
eda17f0
@shama
Backwards compatibility: Return a tree of watched files/relative/unixify
a2f8913
@shama
Detect if no files have been matched and emit nomatch
4326ce8
@shama
Handle rename events in platform
ac7fd14
@shama
Add banners
9ece356
@shama
Clean up watch test
e20e21d
@shama
Ensure we watch newly added files
b20a7aa
@shama
Handle safewrites once again :D
46eeb3a
@shama
Remove the old watch internals R.I.P.
2b74ff4
@shama
clean up
ba61c10
@shama
delay global no longer needed
f2b9a15
@shama
Mine as well update the copyright to 2014 while Im here
0b2dfa7
@shama
Close out deleted filepaths (important for safewrites)
4f1da66
@shama
Delay adding files to watch. Fixes duplicate handle race condition wi…
1a85ddc 
…th rename
@shama
Remove no longer applicable tests
c3a6700 
These tests were for specific cases handled by private methods
that have now been removed and therefore these tests should be removed.
@shama
Cleaner rename test
7bdbe06
@shama
Fix for matching.addedLater test
52a96f9
@shama
Fix for platform test
e854f51
@shama
Better test reset on platform tests
dedf453
@shama
Fix helper for windows
bbf430b
@shama
Handle relative if unixify enabled
7a536a6
@shama
Unixify path sep for Windows tests
2537ed5
@shama
Unixify path sep on platform tests for Windows
f306a8c
@shama
Workaround for rename on linux
7ba7723
@shama
Linux workarounds for platform
1142b66
shama and others added 20 commits August 27, 2014 09:55
@shama
Make emitEvents property private
fec5450
undefined is not a function
6fa4f2b 
From: https://github.com/shama/gaze/blob/master/lib/gaze.js#L260 it is possible that there would be no callback provided as described in https://github.com/shama/gaze/blob/master/lib/platform.js#L118 . I just added a case for when there is no callback provided. I needed this fix for a project of mine. 

Other wise great work Kyle Robinson Young :)

This fix is for the following error

```
TypeError: undefined is not a function
    at Function.platform.close (/server/node/eve/node_modules/gaze/lib/platform.js:112:14)
    at Gaze._trigger (/server/node/eve/node_modules/gaze/lib/gaze.js:249:14)
    at Object.cb (/server/node/eve/node_modules/gaze/lib/platform.js:49:7)
    at /server/node/eve/node_modules/gaze/lib/statpoll.js:32:20
    at iterate (/server/node/eve/node_modules/gaze/lib/helper.js:106:5)
    at /server/node/eve/node_modules/gaze/lib/helper.js:116:11
    at /server/node/eve/node_modules/gaze/lib/statpoll.js:47:5
    at iterate (/server/node/eve/node_modules/gaze/lib/helper.js:106:5)
    at /server/node/eve/node_modules/gaze/lib/helper.js:116:11
    at /server/node/eve/node_modules/gaze/lib/statpoll.js:47:5
```
@shama
Merge pull request shama#150 from cblanquera/master
f9db239 
undefined is not a function
@deepak1556
upgrade template definitions with latest nan
199eaca
@shama
try catch fs.stat call on dir. Fixes shamaGH-153.
4e92694
@shama
travis, install npm instead of upgrade
592afd4
@shama
travis, install a [email protected]
4777e81
@shama
Fix test on windows
2084f2f
@bevacqua
https://twitter.com/shamakry/status/534417012915589120
ac8b8bd
@shama
Merge pull request shama#159 from bevacqua/patch-1
2d0a34c 
Update downloads per month
@shama
Merge pull request shama#151 from deepak1556/v0.11_patch
990974a 
upgrade definitions with latest nan
@shama
Revert "upgrade template definitions with latest nan"
0c0b580 
This reverts commit 199eaca.
@ahamid
add support for debouncing leading event
c8e0a7a
@shama
Merge pull request shama#185 from ahamid/debounceLeading-master
b011567 
add support for debouncing leading event
@shama
Remove that nonsense
9a46be2
@shama
Update copyright to 2015
48ff956
@pgilad
update license attribute
dd9b922 
specifying the type and URL is deprecated:

https://docs.npmjs.com/files/package.json#license
http://npm1k.org/
@shama
Merge pull request shama#190 from pgilad/patch-1
3f88234 
update license attribute
@heavyk
bump deps
dcdf10d
@heavyk
import src from [navalgazer](https://github.com/shama/navelgazer)
c4a003c
@heavyk
Copy link
Author

heavyk commented Jun 12, 2015

it's pretty fast too.. so I ported watchify https://github.com/heavyk/gazeify

@heavyk heavyk force-pushed the master branch 2 times, most recently from 32b6749 to 53219ae Compare June 12, 2015 01:12
@heavyk
Copy link
Author

heavyk commented Jun 12, 2015

shit, well it seems that the tests hang on linux for node-0.12 and iojs

however, locally here on OSX and iojs it's all good
EDIT: though I didn't try 0.12, I imagine it's the same

@shama
Copy link
Owner

shama commented Jun 12, 2015

Rad thanks for attempting this!

Have you seen the navelgazer branch? In there I am consuming navelgazer as a dependency and it gets a bit further on the tests with linux. I believe only a couple are failing.

@heavyk
Copy link
Author

heavyk commented Jun 13, 2015

oh, no, I didn't see the navalgazer branch. I'll check it out.

this has been working for me flawlessly on OSX, so for now, I'm just going to leave it.

later today I will be putting this up on the server. it'll get some linux testing then.
when I do that, I'll try and see if I can't figure out why it's hanging on the rename test and get back to you

cheers

@heavyk
Copy link
Author

heavyk commented Jun 13, 2015

real quick: I read through some of your changes now. I had a similar issue when writing another thing.

essentially, when pattern is '**/*.js' or anything with two ** then all subdirs must be explicitly watched.

lol, and I noticed that gaze04 was being used too for old node compat...

ok, I think I can probably get this :) cheers mate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.