Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting noticeDialog: false result doesn't match documentation #16

Open
tayeke opened this issue Sep 6, 2014 · 0 comments
Open

Setting noticeDialog: false result doesn't match documentation #16

tayeke opened this issue Sep 6, 2014 · 0 comments

Comments

@tayeke
Copy link

tayeke commented Sep 6, 2014

When I set noticeDialog to false I still get the default notice dialog. It looks like it's because of how the if statement is written on the following line.
https://github.com/shaneriley/jquery_remember_state/blob/master/source/javascripts/jquery.remember-state.js#L118

if (!this.noticeDialog || !this.noticeDialog.length || !this.noticeDialog.jquery) {
  this.noticeDialog = this._defaultNoticeDialog();
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tayeke