Removing Old Code Redundancy #111
csdechant
started this conversation in
General / Ideas
Replies: 1 comment
-
I'm generally in favor of simplicity and removing what is not being used directly, but oddly enough sometimes the redundant stuff is helpful. For example, DriftDiffusion was useful because it helped me compared how kernels vs BCs were written, but this may be a case where a development guide may be more helpful than keeping old code around. But this is just my rookie opinion! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi everyone, Zapdos is getting to the point were we have some redundancies with older code. Some are within only Zapdos (such as the Drift Diffusion Action replacing the
DriftDiffusion
kernel), but the bigger one is CRANE replacing most of Zapdos old source term kernels. I am opening this discussion to see if we should remove these old objects (since CRANE is downloaded with Zapdos by default), or does anyone see a need to keep these old objects?Beta Was this translation helpful? Give feedback.
All reactions