You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A user may use up the approval allowance for a given limit order after it's submitted, so we need a way for users to approve more separately to creating a new order.
References and additional details
In #8217 we will detect when an order cannot be executed due to insufficient allowance.
We will need users to be able to re-approve somehow, preferably without having to dig around the app or go elsewhere.
Acceptance Criteria
Users can re-approve allowance for a limit order.
Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response
The text was updated successfully, but these errors were encountered:
It looks like both matcha and cowswap just approve unlimited to avoid these headaches. So when the order fills we should just hit them with a revoke your permissions here tooltip, alert, or notification. This will keep them safe, and keep you and @gomesalexandre sane.
@woodenfurniture should we close this after #8383 went in or do we want to keep this as a placeholder for the regular swapper approval architecture/flow?
Overview
A user may use up the approval allowance for a given limit order after it's submitted, so we need a way for users to approve more separately to creating a new order.
References and additional details
In #8217 we will detect when an order cannot be executed due to insufficient allowance.
We will need users to be able to re-approve somehow, preferably without having to dig around the app or go elsewhere.
Acceptance Criteria
Users can re-approve allowance for a limit order.
Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response
The text was updated successfully, but these errors were encountered: