Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users will need to perform allowance approvals separately to submitting limit orders #8358

Open
woodenfurniture opened this issue Dec 13, 2024 · 2 comments
Assignees
Labels
limit orders needs product Requires product input before bounty

Comments

@woodenfurniture
Copy link
Member

Overview

A user may use up the approval allowance for a given limit order after it's submitted, so we need a way for users to approve more separately to creating a new order.

References and additional details

In #8217 we will detect when an order cannot be executed due to insufficient allowance.

We will need users to be able to re-approve somehow, preferably without having to dig around the app or go elsewhere.

Acceptance Criteria

Users can re-approve allowance for a limit order.

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@twblack88
Copy link
Contributor

It looks like both matcha and cowswap just approve unlimited to avoid these headaches. So when the order fills we should just hit them with a revoke your permissions here tooltip, alert, or notification. This will keep them safe, and keep you and @gomesalexandre sane.

@woodenfurniture woodenfurniture self-assigned this Dec 16, 2024
@gomesalexandre
Copy link
Contributor

@woodenfurniture should we close this after #8383 went in or do we want to keep this as a placeholder for the regular swapper approval architecture/flow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
limit orders needs product Requires product input before bounty
Projects
Status: Backlog
Development

No branches or pull requests

3 participants