Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit orders - stale and wrong precision price when switching buy/sell direction #8414

Open
gomesalexandre opened this issue Dec 19, 2024 · 1 comment · May be fixed by #8456
Open

Limit orders - stale and wrong precision price when switching buy/sell direction #8414

gomesalexandre opened this issue Dec 19, 2024 · 1 comment · May be fixed by #8456
Assignees

Comments

@gomesalexandre
Copy link
Contributor

gomesalexandre commented Dec 19, 2024

Overview

Consistently reproducible https://jam.dev/c/b28000cb-62f4-4fa1-9bae-dbc9a4d37765:

  • Get a 100 sell quote for default USDC -> FOX pair (i.e 100 USDC sell)

  • Switch pair and input 100 again (i.e 100 FOX sell, which is too low of a sell amount and shouldn't yield a quote altogether)

  • Notice the price is in the wrong base unit (off by 10^12 in this case i.e the diff between USDC and FOX precision), and is actually totally wrong, i.e it is the same as the previous buy amount
    image

  • Refresh the page and retry all the steps above, this time with 1000 and notice this does not happen
    image

References and additional details

N/A

Acceptance Criteria

  • Cannot get into stale quotes with wrong value and wrong precision

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@gomesalexandre
Copy link
Contributor Author

Note, this is partly fixed by #8394, but is still happening when manually selecting the opposite pair.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

1 participant