Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit orders notifications #8425

Open
gomesalexandre opened this issue Dec 20, 2024 · 0 comments
Open

Limit orders notifications #8425

gomesalexandre opened this issue Dec 20, 2024 · 0 comments
Labels
limit orders needs product Requires product input before bounty

Comments

@gomesalexandre
Copy link
Contributor

gomesalexandre commented Dec 20, 2024

Overview

See hot take from @0xean as a user in https://discord.com/channels/554694662431178782/1318827210483699762/1319407440470741114:

No notification of a fill occuring, its kind of buried. Would be nice to give the user a toast or better notification. Sounds of a fox growling? haha jk

See how CoWSwap does it:

image

References and additional details

N/A

Acceptance Criteria

  • Toasts are toasted when a fill occurs, similar to 1inch
  • We keep track of previous seen state in store not to notify twice
  • If user reopens the app and we detect unseen fills, all those are toasted
  • Stretch: toasts on expired orders too?
  • Stretch: On notification, alternate between "Ring-ding-ding-ding-dingeringeding! Gering-ding-ding-ding-dingeringeding!", "Wa-pa-pa-pa-pa-pa-pow", "Hatee-hatee-hatee-ho!" and "Joff-tchoff-tchoffo-tchoffo-tchoff!" sounds

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
limit orders needs product Requires product input before bounty
Projects
Status: Backlog
Development

No branches or pull requests

1 participant