Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THORChain LP - Error-Handling #8887

Open
gomesalexandre opened this issue Feb 19, 2025 · 2 comments
Open

THORChain LP - Error-Handling #8887

gomesalexandre opened this issue Feb 19, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@gomesalexandre
Copy link
Contributor

Overview

Now that pools are being enabled, we should properly handle errors, which may happen more often than not e.g

Image

References and additional details

N/A

Acceptance Criteria

  • Try and get into a few errored states when depositing, which you shouldn't really have to try much given the current state of things upstream
  • Surface said errors in the client vs. spinning infinitely

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response
@gomesalexandre gomesalexandre added the bug Something isn't working label Feb 19, 2025
@gomesalexandre gomesalexandre mentioned this issue Feb 19, 2025
Merged
1 task
@0xean
Copy link
Contributor

0xean commented Mar 2, 2025

  • Currently spinning indefinitely or showing complete vs showing error correctly
  • retest multiples pools to see what the current state of lp is with TC madness

@0xean
Copy link
Contributor

0xean commented Mar 2, 2025

@shapeshift/operations to give a pass and let engineering know state so we can fix accordingly

@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
ShapeShift Dashboard
Status: Up next / groomed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0xean @gomesalexandre