Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mock thinky connections when doing a build #16

Open
yocontra opened this issue Mar 14, 2016 · 2 comments
Open

mock thinky connections when doing a build #16

yocontra opened this issue Mar 14, 2016 · 2 comments
Assignees

Comments

@yocontra
Copy link
Member

No description provided.

@yocontra yocontra self-assigned this Mar 14, 2016
@stephenlacy
Copy link
Contributor

I needed to add a process.exit(err? err : 0) to the end of the webpack.run cb in the bin/compile file to close the connection when the build finishes.
Do you want to merge a pr for that, or would you rather restructure the compile process to not hold open connections?

@yocontra
Copy link
Member Author

@stevelacy Actually just did that, but the build should not touch the DB since a production build will try to connect to the production DB which is obv not good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants