[thread] Plugin highlight requests

[shaunsingh]

As lua in neovim improves, more and more neovim plugins are starting to pop up. Personally, I try to keep my config light on plugins, so its becoming impossible for me to watch new plugins and add their highlights to the theme quickly

If any of you use plugins that you would like theme highlights for, let me know

1. What plugin it is (link to repo)
2. What highlight groups does it supply
3. What colors would you ideally want

And I will add it as soon as I get time

[Miradorn]

Hey there, thanks for your work on this plugin and the head up.

Currently there are 2 plugins I use that i don't think are supported:

https://github.com/hrsh7th/nvim-cmp (replaces deprecated cmpe) with these highlight groups:

CmpItemAbbr guifg=#D8DEE9
CmpItemAbbrMatch guifg=#5E81AC
CmpItemAbbrMatchFuzzy guifg=#81A1C1
CmpItemKind guifg=#B48EAD
CmpItemMenu guifg=#B48EAD

And https://github.com/Famiu/feline.nvim , which I didn't get around to integrating as of now, since I think it's more complicated than just defining highlight groups (iirc one has to directly configure status line items)

[shaunsingh]

I just added Cmp highlights a few days back (its actually what prompted me to start this issue, a user talked to me about it and I didn't even know cmp used floating windows until now)

For feline, I plan to expose the 16 colors soon, so you can import them via something like nord.colors.nord4_gui if you want nord 4.

[VKondakoff]

Feline author just added the Theme support in the developer branch. It will be good to have Nord theme for Feline.

[dakennguyen]

Hi, nvim 0.6.0 just released and one of their breaking changes is "highlight groups and signs for LSP diagnostics renamed (e.g. LspDiagnosticsDefaultWarning to DiagnosticWarn)"
They still have the old name for backward compatibility but not sure if you want to add the new highlight groups? neovim/neovim@a5bbb93#diff-8df5fbf5803bbea8d9e9d4d8a63f0bac3a32e1925d74990a43c6327fad2aad03R28-R48

[shaunsingh]

@dakennguyen Nord.nvim should support DiagnosticWarn and such, I've linked it to the old LspDiagnostics... highlights

nord.nvim/lua/nord/theme.lua

Lines 286 to 301 in d96e7e3

	DiagnosticVirtualTextWarn = { link = "LspDiagnosticsVirtualTextWarning" },
	DiagnosticUnderlineWarn = { link = "LspDiagnosticsUnderlineWarning" },
	DiagnosticFloatingWarn = { link = "LspDiagnosticsFloatingWarning" },
	DiagnosticSignWarn = { link = "LspDiagnosticsSignWarning" },
	DiagnosticVirtualTextError = { link = "LspDiagnosticsVirtualTextError" },
	DiagnosticUnderlineError = { link = "LspDiagnosticsUnderlineError" },
	DiagnosticFloatingError = { link = "LspDiagnosticsFloatingError" },
	DiagnosticSignError = { link = "LspDiagnosticsSignError" },
	DiagnosticVirtualTextInfo = { link = "LspDiagnosticsVirtualTextInformation" },
	DiagnosticUnderlineInfo = { link = "LspDiagnosticsUnderlineInformation" },
	DiagnosticFloatingInfo = { link = "LspDiagnosticsFloatingInformation" },
	DiagnosticSignInfo = { link = "LspDiagnosticsSignInformation" },
	DiagnosticVirtualTextHint = { link = "LspDiagnosticsVirtualTextHint" },
	DiagnosticUnderlineHint = { link = "LspDiagnosticsUnderlineHint" },
	DiagnosticFloatingHint = { link = "LspDiagnosticsFloatingHint" },
	DiagnosticSignHint = { link = "LspDiagnosticsSignHint" },

@VKondakoff Sorry for the late response, I'll take a look and add it soon

[felipesere]

Could we add support for vim-notify ?

highlight NotifyERRORBorder guifg=#8A1F1F
highlight NotifyWARNBorder guifg=#79491D
highlight NotifyINFOBorder guifg=#4F6752
highlight NotifyDEBUGBorder guifg=#8B8B8B
highlight NotifyTRACEBorder guifg=#4F3552
highlight NotifyERRORIcon guifg=#F70067
highlight NotifyWARNIcon guifg=#F79000
highlight NotifyINFOIcon guifg=#A9FF68
highlight NotifyDEBUGIcon guifg=#8B8B8B
highlight NotifyTRACEIcon guifg=#D484FF
highlight NotifyERRORTitle  guifg=#F70067
highlight NotifyWARNTitle guifg=#F79000
highlight NotifyINFOTitle guifg=#A9FF68
highlight NotifyDEBUGTitle  guifg=#8B8B8B
highlight NotifyTRACETitle  guifg=#D484FF
highlight link NotifyERRORBody Normal
highlight link NotifyWARNBody Normal
highlight link NotifyINFOBody Normal
highlight link NotifyDEBUGBody Normal
highlight link NotifyTRACEBody Normal

[shaunsingh]

Sure!

[par4m]

Can you change the background of lualine to that of that of the colorscheme background (#2E3440), currently it looks like this

And for NvimTree,
highlight NvimTreeStatusLineNC guibg=nvim_treebg guifg=nvim_treebg
highlight StatusLine guibg=nvim_treebg

So that it looks like this,
NvimTree Focused-

Unfocused-

[orjangj]

Would be great if you could add support for neotest.

Here are the default colors used by the plugin:

  hi default NeotestPassed ctermfg=Green guifg=#96F291
  hi default NeotestFailed ctermfg=Red guifg=#F70067
  hi default NeotestRunning ctermfg=Yellow guifg=#FFEC63
  hi default NeotestSkipped ctermfg=Cyan guifg=#00f1f5
  hi default link NeotestTest Normal 
  hi default NeotestNamespace ctermfg=Magenta guifg=#D484FF
  hi default NeotestFocused gui=bold,underline cterm=bold,underline
  hi default NeotestFile ctermfg=Cyan guifg=#00f1f5
  hi default NeotestDir ctermfg=Cyan guifg=#00f1f5
  hi default NeotestIndent ctermfg=Grey guifg=#8B8B8B
  hi default NeotestExpandMarker ctermfg=Grey guifg=#8094b4
  hi default NeotestAdapterName ctermfg=Red guifg=#F70067
  hi default NeotestWinSelect ctermfg=Cyan guifg=#00f1f5 gui=bold
  hi default NeotestMarked ctermfg=Brown guifg=#F79000 gui=bold
  hi default NeotestTarget ctermfg=Red guifg=#F70067
  hi default link NeotestUnknown Normal

Thanks for providing a lua based nord theme btw.

[Slate245]

Hello, first of all, thanks for the theme!

I'd like to request support for color-coded completion kind icons.

Currently, I've snatched this code from reddit:

vim.cmd[[highlight! CmpItemAbbrDeprecated guibg=NONE gui=strikethrough guifg=#808080]]
vim.cmd[[highlight! CmpItemAbbrMatch guibg=NONE guifg=#569CD6]]
vim.cmd[[highlight! CmpItemAbbrMatchFuzzy guibg=NONE guifg=#569CD6]]
vim.cmd[[highlight! CmpItemKindVariable guibg=NONE guifg=#9CDCFE]]
vim.cmd[[highlight! CmpItemKindInterface guibg=NONE guifg=#9CDCFE]]
vim.cmd[[highlight! CmpItemKindText guibg=NONE guifg=#9CDCFE]]
vim.cmd[[highlight! CmpItemKindFunction guibg=NONE guifg=#C586C0]]
vim.cmd[[highlight! CmpItemKindMethod guibg=NONE guifg=#C586C0]]
vim.cmd[[highlight! CmpItemKindKeyword guibg=NONE guifg=#D4D4D4]]

But it uses hex colors instead of proper nord ones and, I think, differs from what VS Code theme uses. I've tried to get colors from theme definition but to no avail. Colors used in the snippet above aren't all mentioned in vscode-dark+ theme json and do not directly correlate to ones used in nord theme, so I gave up.

It seems that colors should be added directly to theme, similarly how it was done for CmpItem<...> ones, and not in users' config.

It also might be that not all relevant colors are here, since I don't see any mention of Enums.

Here's the thread I've snatched the colors from.