Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Path to external storage directory is hardcoded #146

Closed
TarCV opened this issue Sep 3, 2018 · 1 comment
Closed

Path to external storage directory is hardcoded #146

TarCV opened this issue Sep 3, 2018 · 1 comment

Comments

@TarCV
Copy link

TarCV commented Sep 3, 2018

private static final String FORK_DIRECTORY = "/sdcard/fork";

According to Android linter the path to external storage mount directory should not be hardcoded.
For example IDevice#getMountPoint(MNT_EXTERNAL_STORAGE) can be used instead.
I have actually encountered devices where adb shell echo $EXTERNAL_STORAGE returns a path different from /sdcard.

I think it's possible that this issue causes videos not being recorded like in #138

@AndreiZaitcev
Copy link
Member

This should be resolved by ee92adf

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants