-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The pattern 'false' can never match the type 'true' #21
Comments
Hey @thiagomajesk, we don't plan on adding Dialyzer support anytime soon, but PRs are welcome! |
@sheharyarn Thanks for the reply! |
Setting up the dialyxir (https://github.com/jeremyjh/dialyxir
<https://mailtrack.io/trace/link/24f31a9115eb8fe800af13a7a7522e2f5daa76ed?url=https%3A%2F%2Fgithub.com%2Fjeremyjh%2Fdialyxir&userId=1331115&signature=8fdb5e5380bf6f12>)
package in the `dev` env for Que would be a good start. You can check which
parts of the code are throwing the dialyzer warnings and why. Once we know
that, the way to fixing them should be pretty straightforward.
|
The OP already says what and why the problem is.
The second check in the generated I created a prototype recently, though that fails the current test suite. If there is still some interest in this, I will see to create a draft PR next time I get access to the computer and no one deleted my data their :D |
Thanks for your insights @NobbZ! I haven't had the time to look into this yet even though I've been using Fortunately (or unfortunately) If you can draft a PR for this I'm sure it would be very welcome!👍 |
It works in production for us as well, though we do not like the fact that que is the last library that produces code that dialyzer complains about, we have been able to fix all the other dialyzer problems in the code base that we took over, some of them indeed pointing out stuff that only worked by accident. Though I have to say, even if you were running dialyzer, it wouldn't have complained, as dialyzer can not see into macros. Only into "materialzed" code. So unless you were doing |
I finally managed to get back to this and threw away my initial approach. That other approach still tried to stay within the generated module and I think it is much better to have just a single hook, rather than having a "noop" function in every queue module. In theory this is a breaking change as it removes a public function from the generated modules. Though |
Cheers everyone!
I'm having this Dialyzer warning just by implementing the
perform/1
function:There's also another warning:
I'm using VS Code with ElixiLS Fork and Elixir 1.9.4 compiled with OTP 20 (OTP 22 local)
The text was updated successfully, but these errors were encountered: