Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null Reference for "getInsertRecordFunc" #2

Open
aphex opened this issue May 22, 2012 · 1 comment
Open

Null Reference for "getInsertRecordFunc" #2

aphex opened this issue May 22, 2012 · 1 comment

Comments

@aphex
Copy link
Contributor

aphex commented May 22, 2012

I would have grabbed your repo and sent a pull request but i saw your having trouble merging it in. So i figured i would just write the fix here since it is super simple.

Line: 584
File: SqliteStorage.js

Currently: me.getInsertRecordFunc(record, tablename)();
Fix: me.getInsertRecordFunc(record, tablename)(tx);

Need to pass the transaction into the function. Works like a charm now :)

@shepsii
Copy link
Owner

shepsii commented May 23, 2012

Many thanks Ross, I'm adding a commit in now. Really need to work out
how to deal with these pull requests!

On 23/05/2012 00:29, Ross Gerbasi wrote:

I would have grabbed your repo and sent a pull request but i saw your having trouble merging it in. So i figured i would just write the fix here since it is super simple.

Line: 584
File: SqliteStorage.js

Currently: me.getInsertRecordFunc(record, tablename)();
Fix: me.getInsertRecordFunc(record, tablename)(tx);

Need to pass the transaction into the function. Works like a charm now :)


Reply to this email directly or view it on GitHub:
#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants