Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CN Translation #723

Merged
merged 7 commits into from
Nov 25, 2023
Merged

Add CN Translation #723

merged 7 commits into from
Nov 25, 2023

Conversation

jiangfz1997
Copy link
Contributor

Proposed changes

Add Readme CN translation for Chinese users. Resolve #633

Types of changes

What types of changes does your content introduce to this project?
Put an x in the boxes that apply (without "`")

  • Proofreading (fix spelling, grammar, punctuation, accuracy) Proofreading
  • New content (new section, new readme, etc.)
  • Modifications (modifying existing content)
  • Other (please describe)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. Don't hesitate to ask if you're unsure about any of them. We're here to help! This simply reminds us of what we will look for before merging your code.
Note: If you submit code make sure to test it

  • Tested any code that was added/modified in this PR
  • Added external links
  • Added internal links
  • Added images
  • Added videos
  • Added code snippets

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Adding your name to the contributor's list

Comment "@all-contributors please add @your_username for content" to add your name to the contributor's list.
You can change the "content" with any of this

Reviewers:

  • @username

Please ensure that you are not adding any sensitive information like API keys, secrets, passwords, tokens, usernames, or other credentials. Refrain from adding your name, email, or other personal information.

@the-label-bot the-label-bot bot added the kind/documentation kind/documentation label Nov 8, 2023
Copy link

the-label-bot bot commented Nov 8, 2023

The Label Bot has predicted the following:

Category Value Confidence Applied Label
Kind documentation 0.929 ✔️
Size XL 0.764 ✔️

@the-label-bot the-label-bot bot added the size/XL size/XL label Nov 16, 2023
README_cn.md Outdated Show resolved Hide resolved
@jiangfz1997
Copy link
Contributor Author

Hi @shhossain,
Sorry for the late reply, I just fixed the intro issue now it should be able to redirect to the title for each paragraph.

Copy link
Owner

@shhossain shhossain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiangfz1997 No problem. Merging.

@shhossain shhossain merged commit 051a507 into shhossain:main Nov 25, 2023
1 check failed
@shhossain
Copy link
Owner

@all-contributors add @jiangfz1997 for content.

Copy link
Contributor

@shhossain

I've put up a pull request to add @jiangfz1997! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation kind/documentation size/XL size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translating exiting files (any language allowed)
2 participants