Reference ColorCorrections inside of ColorDecisions resolve into full ColorCorrections even if already included

[shidarin]

If a child ColorDecision has a CCref that points to a CC that's included as a CC child of the same CCC, it will resolve to the full CC and be included twice:

In [25]: print ccc.xml
<ColorDecisionList xmlns="urn:ASC:CDL:v1.01">
    <ColorDecision>
        <ColorCorrectionRef ref="001"/>
    </ColorDecision>
    <ColorDecision>
        <ColorCorrection id="002">
            <SOPNode>
                <Slope>1.0 2.0 10.0</Slope>
                <Offset>0.0 0.0 0.0</Offset>
                <Power>1.0 1.0 1.0</Power>
            </SOPNode>
        </ColorCorrection>
    </ColorDecision>
    <ColorDecision>
        <ColorCorrection id="001">
            <SOPNode>
                <Slope>2.9 2.9 2.9</Slope>
                <Offset>-0.1 0.9 2.9</Offset>
                <Power>1.0 1.0 1.0</Power>
            </SOPNode>
        </ColorCorrection>
    </ColorDecision>
</ColorDecisionList>


In [26]: ccc.set_to_ccc()

In [27]: print ccc.xml
<ColorCorrectionCollection xmlns="urn:ASC:CDL:v1.01">
    <ColorCorrection id="001">
        <SOPNode>
            <Slope>2.9 2.9 2.9</Slope>
            <Offset>-0.1 0.9 2.9</Offset>
            <Power>1.0 1.0 1.0</Power>
        </SOPNode>
    </ColorCorrection>
    <ColorCorrection id="001">
        <SOPNode>
            <Slope>2.9 2.9 2.9</Slope>
            <Offset>-0.1 0.9 2.9</Offset>
            <Power>1.0 1.0 1.0</Power>
        </SOPNode>
    </ColorCorrection>
    <ColorCorrection id="002">
        <SOPNode>
            <Slope>1.0 2.0 10.0</Slope>
            <Offset>0.0 0.0 0.0</Offset>
            <Power>1.0 1.0 1.0</Power>
        </SOPNode>
    </ColorCorrection>
</ColorCorrectionCollection>

[shidarin]

Going through the code, we apparently don't do any checks on ColorDecision's refs before including them:

    def build_element_ccc(self):
        """Builds a CCC XML element representing this ColorCollection"""
        ccc_xml = ElementTree.Element('ColorCorrectionCollection')
        ccc_xml.attrib = {'xmlns': self.xmlns}
        if self.input_desc:
            input_desc = ElementTree.SubElement(ccc_xml, 'InputDescription')
            input_desc.text = self.input_desc
        if self.viewing_desc:
            viewing_desc = ElementTree.SubElement(ccc_xml, 'ViewingDescription')
            viewing_desc.text = self.viewing_desc
        for description in self.desc:
            desc = ElementTree.SubElement(ccc_xml, 'Description')
            desc.text = description
        if self.color_corrections:
            for color_correct in self.color_corrections:
                ccc_xml.append(color_correct.element)
        if self.color_decisions:
            # We'll need to extract the ColorCorrections from the
            # ColorDecisions
            for color_decision in self.color_decisions:
                if color_decision.is_ref:
                    color_correction = color_decision.cc.cc
                else:
                    color_correction = color_decision.cc

                # We do one last check to ensure that we actually have a
                # returned ColorCorrection, as ColorCorrectionRef will
                # return None if it's an unresolved reference and no
                # HALT behavior was set.
                if color_correction:
                    ccc_xml.append(color_correction.element)

        return ccc_xml

We need to make use of the id_list attribute to check if this CD should be included, much like how we do in build_element_cdl:

    def build_element_cdl(self):
        """Builds a CDL XML element representing this ColorCollection"""
        cdl_xml = ElementTree.Element('ColorDecisionList')
        cdl_xml.attrib = {'xmlns': self.xmlns}
        if self.input_desc:
            input_desc = ElementTree.SubElement(cdl_xml, 'InputDescription')
            input_desc.text = self.input_desc
        if self.viewing_desc:
            viewing_desc = ElementTree.SubElement(cdl_xml, 'ViewingDescription')
            viewing_desc.text = self.viewing_desc
        for description in self.desc:
            desc = ElementTree.SubElement(cdl_xml, 'Description')
            desc.text = description
        if self.color_decisions:
            for color_decision in self.color_decisions:
                if color_decision.cc.id in self.id_list:
                    resolve = False
                else:
                    try:
                        color_correction = color_decision.cc.cc
                    except ValueError:
                        # ValueError will be raised if we can't resolve the
                        # reference. This shouldn't be a game-stopper here.
                        #
                        # We'll just add the unresolved reference
                        resolve = False
                    else:
                        resolve = True if color_correction else False

                cdl_xml.append(color_decision.build_element(resolve=resolve))

        if self.color_corrections:
            # We'll create some temporary ColorDecision instances, and place
            # the ColorCorrects inside of them.
            #
            # We need to store the ColorDecision member dictionary, so that
            # we can return it to the state it was in prior to us creating
            # these temporary ColorDecisions
            color_decisions_members = ColorDecision.members

            for color_correction in self.color_corrections:
                color_decision = ColorDecision(color_correction)
                cdl_xml.append(color_decision.element)

            # Now reset the ColorDecision member dictionary to the state it was
            # in prior to us creating temp ColorDecisions
            ColorDecision.members = color_decisions_members

        return cdl_xml

[shidarin]

Note that the fix for Issue #42 will also have this problem, so the code in cdl_convert's main script needs to be fixed as well.