Cairo grammar breaks when upgrading to 1.24

[julio4]

Validations

• Follow our Code of Conduct
• Read the Contributing Guide.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

Describe the bug

Without any changes in the grammar, it seems upgrading from 1.23 to ^1.24 cause unexpected breaking changes.
In my case it breaks the cairo highlighting.

It can be easily reproduced with tm-grammars previews: https://deploy-preview-100--textmate-grammars-themes.netlify.app/?theme=github-dark&grammar=cairo (from shikijs/textmate-grammars-themes#100) (shiki 1.20.0, but it works in 1.23.1 as well)

Compared to the current version:

Reproduction

textmate grammars preview

Contributes

• I am willing to submit a PR to fix this issue
• I am willing to submit a PR with failing tests

[slevithan]

Note: This is affecting both the Oniguruma and JavaScript engine.

Without any changes in the grammar, it seems upgrading from 1.23 to ^1.24 cause unexpected breaking changes. In my case it breaks the cairo highlighting.

But the Cairo grammar did change significantly (see shikijs/textmate-grammars-themes@71926b1), and based on the dates, it looks like this update shipped in Shiki 1.24.1.

[slevithan]

@antfu Should the change to the Cairo grammar source (from your commit I linked to above) be reverted? Looks like the new grammar does a very poor job of highlighting Shiki's Cairo source sample.

In fact, the updated grammar repo (starkware-libs/cairo-lang) says the following:

This extension provides support for the older version of Cairo, known as CairoZero. For the new language, install the Cairo 1.0 extension. Note that the CairoZero compiler and extension are no longer maintained. This extension should only be used by projects that still rely on CairoZero code.

From https://github.com/starkware-libs/cairo-lang/tree/master/src/starkware/cairo/lang/ide/vscode-cairo

I'm guessing you swapped the grammar source (from starkware-libs/cairo to starkware-libs/cairo-lang) because the tmLanguage file no longer seems to exist in the prior repo. But the substitute doesn't seem correct. So maybe Cairo should just be removed from Shiki's tm-grammars for now, unless another source is identified.

[antfu]

If anyone find a better source of the grammar, please send a PR to update https://github.com/shikijs/textmate-grammars-themes/blob/main/sources-grammars.ts#L24