Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch support for mirror libraries #14

Open
cliffano opened this issue Mar 25, 2019 · 0 comments
Open

Branch support for mirror libraries #14

cliffano opened this issue Mar 25, 2019 · 0 comments

Comments

@cliffano
Copy link
Contributor

cliffano commented Mar 25, 2019

Currently mirror libraries only support versioned releases, but we also need to add support for branch download.

Need to refactor AocMirrorGithubLibrary to do the following:

  • check if branch exists, then download branch artifact at https://github.com/${user}/${repo}/archive/${branch}.tar.gz , and then repackage this artifact to remove the ${repo}/${branch} subdir, this way it's consistent with the released version which doesn't have such subdir
  • check if version exists, then download released version at https://github.com/${user}/${repo}/releases/download/${version}/${repo}-${version}.tar.gz
  • otherwise, log error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant