Skip to content

Commit 8935f38

Browse files
committed
Removed unnecessary validation in schemas
1 parent 54f74c6 commit 8935f38

File tree

3 files changed

+5
-32
lines changed

3 files changed

+5
-32
lines changed

src/schemas/contacts.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -21,22 +21,6 @@ class CreateContactRequest(BaseModel):
2121
json_schema_extra={"example": "+1234567890"}
2222
)
2323

24-
@field_validator("name")
25-
def validate_name(cls, value):
26-
if len(value) < 1 or len(value) > 50:
27-
raise ValueError("Name must be between 1 and 50 characters.")
28-
return value
29-
30-
@field_validator("phone")
31-
def validate_phone(cls, value):
32-
if not value.startswith("+"):
33-
raise ValueError("Phone numbers must start with a '+' prefix.")
34-
if not value[1:].isdigit():
35-
raise ValueError("Phone numbers must contain only digits after the '+' prefix.")
36-
if len(value) < 10 or len(value) > 15:
37-
raise ValueError("Phone numbers must be between 10 and 15 characters.")
38-
return value
39-
4024

4125
class Contact(BaseModel):
4226
"""

src/schemas/messages.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -59,14 +59,6 @@ class CreateMessageRequest(BaseModel):
5959
json_schema_extra={"example": "+0987654321"}
6060
)
6161

62-
@field_validator("from_sender")
63-
def validate_phone_number(cls, value):
64-
if not value.startswith("+"):
65-
raise ValueError("Phone numbers must include the '+' prefix.")
66-
if not value[1:].isdigit():
67-
raise ValueError("Phone numbers must contain only digits after the '+' prefix.")
68-
return value
69-
7062

7163
class Message(BaseModel):
7264
"""

src/sdk/client.py

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,22 +35,19 @@ def _handle_api_errors(self, response: requests.Response) -> None:
3535
ServerError: For other 500+ server errors.
3636
ApiError: Generic API error for unexpected status codes.
3737
"""
38-
if response.status_code == 204: # No Content
39-
logger.info("No content returned. Operation successful.")
40-
return
41-
elif response.status_code == 401:
38+
if response.status_code == 401:
4239
logger.error(f"Unauthorized: {response.text}")
4340
raise UnauthorizedError("Unauthorized. Check your API key.")
44-
elif response.status_code == 404:
41+
if response.status_code == 404:
4542
logger.error(f"Resource Not Found: {response.text}")
4643
raise NotFoundError("Resource not found.")
47-
elif response.status_code in (502, 503):
44+
if response.status_code in (502, 503):
4845
logger.warning(f"Transient Error: {response.text}")
4946
raise TransientError("Transient server error. Please retry.", status_code=response.status_code)
50-
elif response.status_code >= 500:
47+
if response.status_code >= 500:
5148
logger.error(f"Server Error: {response.text}")
5249
raise ServerError("Server error. Please try again later.")
53-
elif not response.ok:
50+
if not response.ok:
5451
logger.error(f"Unhandled API Error: {response.status_code} - {response.text}")
5552
raise ApiError(f"Unhandled API Error: {response.status_code}: {response.text}")
5653

0 commit comments

Comments
 (0)