Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NumFDs on Windows #1455

Closed
braydonk opened this issue Apr 27, 2023 · 1 comment
Closed

Support NumFDs on Windows #1455

braydonk opened this issue Apr 27, 2023 · 1 comment

Comments

@braydonk
Copy link

Describe the solution you'd like
I would like to add support for the NumFDs method in Windows.

Describe alternatives you've considered
OpenFiles is implemented for Windows, however doesn't cover all the information; Windows process handles can be more than just

Additional context
I opened #1454 as a draft to demonstrate a solution that I think makes sense for getting the full number of handles. However this may not be the way to go, because there is some nuance between "Handle" in Windows and "File Descriptor". In POSIX we're only considered about fds, but in Windows we may like to know about all handles.

FWIW, psutil simply has different methods for Windows and Linux (num_handles and num_fds respectively). Do we want to try and make a distinction like that here? I don't know how this library likes to handle differences in interface between platforms.

@braydonk
Copy link
Author

braydonk commented Oct 1, 2024

This was done in #1712 so I'll close this.

@braydonk braydonk closed this as completed Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants