Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestDisk_partitions fails when there are no physical drives mounted #1654

Open
gibmat opened this issue May 23, 2024 · 1 comment
Open

TestDisk_partitions fails when there are no physical drives mounted #1654

gibmat opened this issue May 23, 2024 · 1 comment

Comments

@gibmat
Copy link

gibmat commented May 23, 2024

Describe the bug
TestDisk_partitions fails when there are no physical drives mounted:

=== RUN   TestDisk_partitions
    disk_test.go:38: error <nil>
    disk_test.go:40: []
    disk_test.go:43: ret is empty
--- FAIL: TestDisk_partitions (0.00s)

To Reproduce
Per the Debian bug report, this occurs with the sbuild unshare backend.

Expected behavior
The test detects there are no disks and is skipped.

Environment (please complete the following information):
Debian sid

Additional context
Originally reported as Debian bug #1071190, forwarding upstream.

@shirou
Copy link
Owner

shirou commented May 28, 2024

Thank you for the report. I believe this test is necessary to detect the issue where drives are no longer recognized. The environment where physical drives do not exist is quite rare, so I don't think we can remove this test to accommodate that scenario.

@Lomanic Lomanic added the tests label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants