Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RateStock is bad for most of stocks #27

Open
shivamsouravjha opened this issue Oct 12, 2024 · 2 comments
Open

fix: RateStock is bad for most of stocks #27

shivamsouravjha opened this issue Oct 12, 2024 · 2 comments
Labels
enhancement New feature or request golang good first issue Good for newcomers hacktoberfest

Comments

@shivamsouravjha
Copy link
Owner

  • most of stocks don't have rating there are few issues with rating.
@shivamsouravjha shivamsouravjha added enhancement New feature or request good first issue Good for newcomers hacktoberfest golang labels Oct 12, 2024
@ayesparshh
Copy link

I guess the problem comes when a particular stock doesn't have a P/E ratio or a market cap maybe a nil checker will do the work? correct me please if I'm wrong?

@shivamsouravjha
Copy link
Owner Author

Seems like so, one way can be adding the check and since most of my data is present in the mongo dump we can run a script to get the list of stocks for whom this data is wrong , I will fix the data for those by scrapping correct info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request golang good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants