Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presentation mode button is missing #23

Closed
Aarass opened this issue Dec 1, 2024 · 7 comments · May be fixed by #25
Closed

Presentation mode button is missing #23

Aarass opened this issue Dec 1, 2024 · 7 comments · May be fixed by #25
Labels
bug Something isn't working chrome This issue affects the Chrom(ium) variant

Comments

@Aarass
Copy link

Aarass commented Dec 1, 2024

I can't find a way to enter presentation mode. Is it removed in the latest version? Why?

@shivaprsd
Copy link
Owner

Did you check the 》menu on the top right corner? Presentation mode has been under that menu since a long time.

If it is not even there, can you give more details (browser & OS version, doqment version) and a screenshot? Thanks!

@shivaprsd shivaprsd added question Further information is requested viewer This is specific to the PDF.js viewer labels Dec 2, 2024
@Aarass
Copy link
Author

Aarass commented Dec 2, 2024

Yes, it was there since like two weeks ago.
I'm using Chrome on Windows 11
doqment version 0.9.1

Screenshot 2024-12-02 160715

@shivaprsd
Copy link
Owner

Indeed, you are right! Since the last Chrome update, the viewer is loaded in an iframe, and I didn't explicitly set its permission to request fullscreen. The PDF.js library was reading the (lack of) permission and hiding the button.

It is a straight-forward fix, I will update and push a new minor release this week. Thanks for bringing this to my notice!

@shivaprsd shivaprsd added bug Something isn't working work-in-progress This is being worked on chrome This issue affects the Chrom(ium) variant and removed question Further information is requested viewer This is specific to the PDF.js viewer labels Dec 2, 2024
@shivaprsd
Copy link
Owner

shivaprsd commented Dec 3, 2024

@Aarass Meanwhile, just out of curiosity: do you use presentation mode to actually present PDFs on a screen/projector, or only for fullscreen reading?

Because with Page Scrolling mode, going fullscreen with F11/Chrome menu and hiding the PDF toolbar with F3 achieves nearly the same effect (that's three steps instead of one, but still).

@Aarass
Copy link
Author

Aarass commented Dec 4, 2024

I use it only for fullscreen reading.

The three steps you mentioned almost work. However, the issue I’m having is that I can see the scrollbar at almost all zoom levels. The automatic zoom options leave a small amount of scrolling for some reason (I suspect it’s due to the padding around the page). The scrollbar disappears when I choose a small zoom level, like 50%, but then, what’s the point?

@shivaprsd
Copy link
Owner

shivaprsd commented Dec 4, 2024

I agree, it is not the exact same experience. As I said, the fix is on the way. Thanks for your patience!

(By the way, I think the zoom level is more like Page Fit in Presentation mode. And you cannot change it, so the above trick is useful if someone also needs to zoom in fullscreen, if they don't mind the scrollbars)

@shivaprsd
Copy link
Owner

This is now fixed in v0.9.2. The update should be live on the store in a few hours. Sorry for the delay!

@shivaprsd shivaprsd removed the work-in-progress This is being worked on label Dec 16, 2024
@Aarass Aarass closed this as completed Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chrome This issue affects the Chrom(ium) variant
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants